Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1391013006: Call known TLS destructors on Windows (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Call known TLS destructors on Windows Partially fixes #23474 by freeing the MonitorWaitData and Thread objects on Windows when a thread exits. Machinery to run a function at thread exit on Windows taken from Chromium's base. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1ec9d78b89303a7a45dc99db8e886be77005bf3b

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -2 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/os_thread_win.cc View 1 3 chunks +86 lines, -1 line 0 comments Download
M runtime/vm/thread.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/thread_test.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 2 months ago (2015-10-13 17:41:39 UTC) #2
siva
lgtm with one comment about moving Thread::Cleanup entirely into os_thread_win.cc and avoiding the ugly #ifdef ...
5 years, 2 months ago (2015-10-13 21:30:54 UTC) #3
Cutch
https://codereview.chromium.org/1391013006/diff/1/runtime/vm/thread.cc File runtime/vm/thread.cc (right): https://codereview.chromium.org/1391013006/diff/1/runtime/vm/thread.cc#newcode536 runtime/vm/thread.cc:536: } On 2015/10/13 21:30:54, siva wrote: > Ditto comment. ...
5 years, 2 months ago (2015-10-14 14:43:18 UTC) #4
Cutch
5 years, 2 months ago (2015-10-14 14:59:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1ec9d78b89303a7a45dc99db8e886be77005bf3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698