mojo/devtools/common/mojo_benchmark - Issue 1391013005: Benchmark: `--save-all-traces` argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/devtools/common/mojo_benchmark

Issue 1391013005: Benchmark: `--save-all-traces` argument (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Benchmark Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/devtools/common/mojo_benchmark

diff --git a/mojo/devtools/common/mojo_benchmark b/mojo/devtools/common/mojo_benchmark

index fc0258e09967aebbec025930fd2081c3b1ec865a..8f83c5be4ef87c84ae84327a6e248e1043bbb702 100755

--- a/mojo/devtools/common/mojo_benchmark

+++ b/mojo/devtools/common/mojo_benchmark

@@ -148,7 +148,7 @@ def main():

description=_DESCRIPTION)

parser.add_argument('benchmark_list_file', type=file,

help='a file listing benchmarks to run')

- parser.add_argument('--save-traces', action='store_true',

+ parser.add_argument('--save-all-traces', action='store_true',

help='save the traces produced by benchmarks to disk')

perf_dashboard.add_argparse_server_arguments(parser)

@@ -179,7 +179,7 @@ def main():

measurements = variant_spec['measurements']

output_file = None

- if script_args.save_traces:

+ if script_args.save_all_traces:

output_file = 'benchmark-%s-%s-%s.trace' % (

benchmark_name.replace(' ', '_'),

variant_name.replace(' ', '_'),

« no previous file with comments | « apps/benchmark/benchmark_app.cc ('k') | no next file » | no next file with comments »