Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 13910011: Add optimization to TextureLayer (Closed)

Created:
7 years, 8 months ago by David Trainor- moved to gerrit
Modified:
7 years, 8 months ago
Reviewers:
danakj, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Add optimization to TextureLayer Since there's no way to query UV coords, we shouldn't be committing if we have to push UV every frame. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195248

Patch Set 1 #

Patch Set 2 : Added unitt est #

Total comments: 2

Patch Set 3 : Moved define to layer_test_common.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -6 lines) Patch
M cc/layers/layer_unittest.cc View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M cc/layers/texture_layer.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 1 2 2 chunks +19 lines, -0 lines 0 comments Download
M cc/test/layer_test_common.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
David Trainor- moved to gerrit
ptal
7 years, 8 months ago (2013-04-18 00:19:41 UTC) #1
danakj
LGTM
7 years, 8 months ago (2013-04-18 00:29:23 UTC) #2
enne (OOO)
On 2013/04/18 00:29:23, danakj wrote: > LGTM This could use a unit test too, on ...
7 years, 8 months ago (2013-04-18 00:34:17 UTC) #3
David Trainor- moved to gerrit
Added test. ptal https://codereview.chromium.org/13910011/diff/5001/cc/layers/texture_layer_unittest.cc File cc/layers/texture_layer_unittest.cc (right): https://codereview.chromium.org/13910011/diff/5001/cc/layers/texture_layer_unittest.cc#newcode28 cc/layers/texture_layer_unittest.cc:28: #define EXPECT_SET_NEEDS_COMMIT(expect, code_to_test) do { \ ...
7 years, 8 months ago (2013-04-18 20:33:44 UTC) #4
enne (OOO)
lgtm https://codereview.chromium.org/13910011/diff/5001/cc/layers/texture_layer_unittest.cc File cc/layers/texture_layer_unittest.cc (right): https://codereview.chromium.org/13910011/diff/5001/cc/layers/texture_layer_unittest.cc#newcode28 cc/layers/texture_layer_unittest.cc:28: #define EXPECT_SET_NEEDS_COMMIT(expect, code_to_test) do { \ On 2013/04/18 ...
7 years, 8 months ago (2013-04-18 20:40:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/13910011/11001
7 years, 8 months ago (2013-04-18 21:27:31 UTC) #6
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
7 years, 8 months ago (2013-04-19 07:33:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/13910011/11001
7 years, 8 months ago (2013-04-19 17:41:29 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 18:46:23 UTC) #9
Message was sent while issue was closed.
Change committed as 195248

Powered by Google App Engine
This is Rietveld 408576698