Add the --nosvn property to the chromium solution.

Add the --nosvn property to the chromium solution.

This allows non-committers to use fetch to checkout chromium or blink using

$ fetch chromium --nosvn=true

BUG=230357
R=dpranke@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193713

[Mike West, 2013-04-11 14:03:48]

Looks good (unofficially)! Thanks for doing this; I've had a few people asking
about it.

https://codereview.chromium.org/13910005/diff/1/recipes/chromium.py
File recipes/chromium.py (right):

https://codereview.chromium.org/13910005/diff/1/recipes/chromium.py#newcode33
recipes/chromium.py:33: solution_type = 'gclient_git_svn'
Nit: "Solution" seems like a weird name for this. Is it a gyp term of art?
Otherwise, I'd suggest 'checkout_type' or 'recipe_type' or something similar.
*shrug*

[jochen (gone - plz use gerrit), 2013-04-11 14:20:02]

https://codereview.chromium.org/13910005/diff/1/recipes/chromium.py
File recipes/chromium.py (right):

https://codereview.chromium.org/13910005/diff/1/recipes/chromium.py#newcode33
recipes/chromium.py:33: solution_type = 'gclient_git_svn'
On 2013/04/11 14:03:48, Mike West (chromium) wrote:
> Nit: "Solution" seems like a weird name for this. Is it a gyp term of art?
> Otherwise, I'd suggest 'checkout_type' or 'recipe_type' or something similar.
> *shrug*

Done.

[Dirk Pranke, 2013-04-11 17:02:48]

Aaron has a patch for this that's been posted for a few days:

https://codereview.chromium.org/13743002/

I'm not sure why that one hasn't been landed yet, but he needs to either land
that or sign off on this one (I haven't looked at this patch at all yet, so
can't comment on the relative merits of them).

[plz use chromium.org account, 2013-04-11 17:11:15]

My change doesn't duplicate the fit checkout code :-)

[agable, 2013-04-11 18:00:17]

LGTM

My change hadn't gone in because I hadn't had a chance to address the comments
from dpranke@ and iannucci@. This is virtually identical to my post-response
version. This should go in in favor of mine since it's ready now.

https://codereview.chromium.org/13910005/diff/5001/recipes/chromium.py
File recipes/chromium.py (right):

https://codereview.chromium.org/13910005/diff/5001/recipes/chromium.py#newcode34
recipes/chromium.py:34: if props.get('nosvn'):
Due to current options processing (which I'm in the process of fixing, but
hasn't been fixed yet) this means that passing --nosvn=<anything> will result in
a git-only checkout. Doesn't have to be --nosvn=True. I'm fine with that, but
wanted to make sure that's what you intended.

[Dirk Pranke, 2013-04-11 19:58:40]

lgtm

[jochen (gone - plz use gerrit), 2013-04-11 20:03:18]

Committed patchset #2 manually as r193713.