Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: content/browser/loader/cross_site_resource_handler.cc

Issue 1390983004: Add CHECK failure to XSRH, to detect which tests exercise this case via a tryjob. Base URL: https://chromium.googlesource.com/chromium/src.git@no_isolate_apps3
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/cross_site_resource_handler.cc
diff --git a/content/browser/loader/cross_site_resource_handler.cc b/content/browser/loader/cross_site_resource_handler.cc
index 0b9e6a77aa1f38a0dd34b668a1681bedc5d9fcbe..47c5390f9672fcb57d14e6d3d47fcc0634154a37 100644
--- a/content/browser/loader/cross_site_resource_handler.cc
+++ b/content/browser/loader/cross_site_resource_handler.cc
@@ -96,8 +96,10 @@ CheckNavigationPolicyOnUI(GURL real_url, int process_id, int render_frame_id) {
// Without a valid RFH against which to check, we must cancel the request,
// to prevent the resource at |url| from being delivered to a potentially
// unsuitable renderer process.
- if (!rfh)
+ if (!rfh) {
+ CHECK(false);
return CrossSiteResourceHandler::NavigationDecision::CANCEL_REQUEST;
+ }
RenderFrameHostManager* manager = rfh->frame_tree_node()->render_manager();
if (manager->IsRendererTransferNeededForNavigation(rfh, real_url))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698