Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1390933007: [Android] Removed unnecessary only_output_failures field. (Closed)

Created:
5 years, 2 months ago by mikecase (-- gone --)
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Removed unnecessary only_output_failures field. The bug preventing us from outputting passed tests was fixed. This field does nothing anymore except prints out "See logcat for more results information" which isn't really neccessary anymore. BUG= Committed: https://crrev.com/69fde2cf4bacbfc82de8a3ef6243645b7c948476 Cr-Commit-Position: refs/heads/master@{#354125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M build/android/pylib/remote/device/remote_device_environment.py View 1 chunk +0 lines, -5 lines 0 comments Download
M build/android/pylib/remote/device/remote_device_gtest_run.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mikecase (-- gone --)
Not really sure why I didn't delete this earlier. Cleaning it up now.
5 years, 2 months ago (2015-10-14 20:33:03 UTC) #2
jbudorick
lgtm
5 years, 2 months ago (2015-10-14 20:47:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390933007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390933007/1
5 years, 2 months ago (2015-10-14 20:52:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-14 21:57:25 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 21:58:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69fde2cf4bacbfc82de8a3ef6243645b7c948476
Cr-Commit-Position: refs/heads/master@{#354125}

Powered by Google App Engine
This is Rietveld 408576698