Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1390923002: Revert of win: Update to Win 10 SDK (Closed)

Created:
5 years, 2 months ago by scottmg
Modified:
5 years, 2 months ago
Reviewers:
sky, brucedawson
CC:
chromium-reviews, tfarina, Nico, Jim Stichnoth, Petr Hosek, Karl, Junichi Uekawa, Sam Clegg, cdotstout, Roland McGrath
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of win: Update to Win 10 SDK (patchset #7 id:120001 of https://codereview.chromium.org/1378153003/ ) Reason for revert: Suspected of causing compile timeouts on Win builders. e.g. http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/14141 OTOH, all trybots were fine, I can't repro in a VM, and some of the compiles on waterfall are fine. So... needs some investigation. Original issue's description: > win: Update to Win 10 SDK > > Tested on clean Win7 VM against both VS2013 and clang=1 at 247874-1. > > NaCl roll has to be included here because clang-cl warns if _WIN32_WINNT differs when building NaCl in Chrome. Roll includes: > > https://chromium.googlesource.com/native_client/src/native_client/+log/719fce7fa0..9c69f1fcb3 > > d:\src\cr3\src>git log 719fce7fa0c1f11cf05d5c20cdfa6648e8a35611..9c69f1fcb35b34f136da7ea7c91ceb743b9d2aaa --pretty=oneline > 9c69f1fcb35b34f136da7ea7c91ceb743b9d2aaa win: Update to Windows 10 SDK > bc87a5bbc9664e22fcfe01786d501d70f198b22f Update revision for PNaCl > 8d12493d902fec4c91dc949ab3a553c680b354a5 Use -fgnu-inline-asm for non-SFI IRT GYP build > a27e828a3f1408197fbe39a5649e0b12f5b83e5d PNaCl: Update llvm and subzero revision in pnacl/COMPONENT_REVISIONS > 11234b3082981faaf98b3045b907e19dd15b2737 Make ncval_annotate accept command-line options for paths. > 0825b8b3e036f434375963458f090287e98be57f Fix failure of NaClHostDirOpen("/") on windows > b73b0a27a2f833e7937c69dcbceda60cf522cd24 Add a test for x86-32 IRT stack realignment > 67569a6bf3dfbdc8392e3aed95fcab4a3b49865b Add --finalize option to pnacl-ld > 89c677938dec5ee5460c40731f5a4028c5c39527 Build non-SFI version of sandboxed binaries > 9906fe25373ca728aed81a6a3e944a42c0603298 Remove per-file *.gn from OWNERS > 564d7b6489425339c1a4d667874f51a3ce3d8b0f Add x86 and x64 into the list of supported PNaCl architectures > ea4179990a6d0a3570ca53fcd6d898df6ef0a408 PNaCl: Remove the -allow-asm option > 8a68b7b483492ebd918b7cbd315a3b7738b2efee PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS > 04d56826368fc7fcd5a802c1e3794c1abb4b3978 Build support for fnl. > dafabd1973dad64651ab2ed93fabec9415843ff4 GN: Conditionalize x86-specific validator bits > 9f06ea989d1257827a402be1b45cd0450296959a [Docs] Add wiki content to Markdown docs > 644c971c7e492740d0fe0f997b9f5b01a23727fc PNaCl: Update subzero revision in pnacl/COMPONENT_REVISIONS > 13f84b78ff6a702434b1501fc06643a4c1721998 debug_stub: Avoid unused const warning on non-x86 builds > > R=brucedawson@chromium.org > BUG=491424 > > Committed: https://crrev.com/3f6f89251dc210b24a36398237d374a87d4a3b33 > Cr-Commit-Position: refs/heads/master@{#352667} TBR=brucedawson@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=491424 Committed: https://crrev.com/2adcdde0c31366f8b6a5a1f6deb301abbd92e91f Cr-Commit-Position: refs/heads/master@{#352714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -23 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 5 chunks +12 lines, -12 lines 0 comments Download
M build/config/win/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/window_finder_win.cc View 2 chunks +23 lines, -2 lines 0 comments Download
M third_party/usrsctp/usrsctp.gyp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
Created Revert of win: Update to Win 10 SDK
5 years, 2 months ago (2015-10-06 23:39:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390923002/1
5 years, 2 months ago (2015-10-06 23:42:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 23:47:32 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2adcdde0c31366f8b6a5a1f6deb301abbd92e91f Cr-Commit-Position: refs/heads/master@{#352714}
5 years, 2 months ago (2015-10-06 23:49:09 UTC) #4
brucedawson
5 years, 2 months ago (2015-10-07 00:01:34 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698