Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1390913007: Remove //build/module_args/nacl.gni (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
Reviewers:
Roland McGrath
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove //build/module_args/nacl.gni It is now completely unused. R=mcgrathr@chromium.org BUG= Committed: https://crrev.com/ed48a698b35b4900a124804b89ff6e408a8a430d Cr-Commit-Position: refs/heads/master@{#353417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
D build/module_args/nacl.gni View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dirk Pranke
5 years, 2 months ago (2015-10-09 22:17:37 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390913007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390913007/1
5 years, 2 months ago (2015-10-09 22:25:08 UTC) #3
Roland McGrath
lgtm
5 years, 2 months ago (2015-10-09 22:35:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-09 22:57:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390913007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390913007/1
5 years, 2 months ago (2015-10-09 23:07:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 23:17:28 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 23:18:19 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ed48a698b35b4900a124804b89ff6e408a8a430d
Cr-Commit-Position: refs/heads/master@{#353417}

Powered by Google App Engine
This is Rietveld 408576698