add applyFilter() to SkImage

add applyFilter() to SkImage

Result:
- clients can get a filtered version of an image without having to setup a temp drawing environment
- for some cases, the process is more efficient even than (deprecated) drawSprite, since there is no need to draw/copy the result

Impl:
- made Proxy virtual so we don't need to have an existing device to use it

This, in conjunction with LocalMatrixImageFilter, should allow us to simplify and optimize ApplyImageFilter() in cc/output/gl_renderer.cc

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/88d064d0e481949184305c7b1d6b282dddffac39

[reed1, 2015-10-09 16:44:07]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-09 16:44:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390913005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390913005/1

[commit-bot: I haz the power, 2015-10-09 16:45:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-09 16:45:21]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[reed1, 2015-10-09 16:45:43]

reed@google.com changed reviewers:
+ robertphillips@google.com, senorblanco@google.com

[reed1, 2015-10-09 16:45:44]

with this, perhaps we can eliminate the need for drawSprite, and in the case of
the CC client, eliminate having to draw anything but use this new API instead.

[reed1, 2015-10-09 20:08:37]

will write some tests for this, but the impl is ready for initial review.

[reed1, 2015-10-09 20:08:45]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-09 20:08:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390913005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390913005/20001

[commit-bot: I haz the power, 2015-10-09 20:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-09 20:15:51]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-10-12 16:02:52]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-12 16:03:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390913005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390913005/40001

[commit-bot: I haz the power, 2015-10-12 16:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 16:05:42]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[reed1, 2015-10-12 16:06:33]

PTAL

[reed1, 2015-10-12 16:10:06]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-12 16:10:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390913005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390913005/60001

[commit-bot: I haz the power, 2015-10-12 16:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 16:11:14]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[robertphillips, 2015-10-12 16:43:33]

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp
File gm/spritebitmap.cpp (right):

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp#new...
gm/spritebitmap.cpp:125: SkPaint paint;
sk_tool_utils::color_to_565 ?

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp#new...
gm/spritebitmap.cpp:169: 
put "offset1.setZero();" on its own line or use "= { 0, 0 }" ?

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp#new...
gm/spritebitmap.cpp:176: show_image(canvas, image0, SkIPoint::Make(0, 0));
150 -> kImageWHWithPath ?

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp#new...
gm/spritebitmap.cpp:181: {
// draw with old paths (drawSprite & drawImage w/ filter) for comparison ?

https://codereview.chromium.org/1390913005/diff/60001/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/1390913005/diff/60001/include/core/SkImage.h#...
include/core/SkImage.h:312: *
need -> needed

https://codereview.chromium.org/1390913005/diff/60001/include/core/SkImage.h#...
include/core/SkImage.h:317: *      If the filter makes the result larger by a
margin of 4 the output would be:
odd mix of ->/. and =/==

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage.cpp#n...
src/image/SkImage.cpp:72: if (!filter) {
Just return this with offset set to 0,0 ?

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage.cpp#n...
src/image/SkImage.cpp:77: if (!offset) {
init offsetStorage to 0,0 here ?

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage.cpp#n...
src/image/SkImage.cpp:87: 
const SkIRect& srcBounds ?

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage_Gpu.c...
src/image/SkImage_Gpu.cpp:244: return new SkImage_Gpu(dst.width(), dst.height(),
kNeedNewImageUniqueID, info.alphaType(),
unbudgeted ?

[reed1, 2015-10-12 17:08:45]

https://codereview.chromium.org/1390913005/diff/60001/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/1390913005/diff/60001/include/core/SkImage.h#...
include/core/SkImage.h:317: *      If the filter makes the result larger by a
margin of 4 the output would be:
On 2015/10/12 16:43:32, robertphillips wrote:
> odd mix of ->/. and =/==

Written from the caller's perspective, where result will be a ptr, and offset
will not. Suggested rewrite for this section?

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage.cpp#n...
src/image/SkImage.cpp:72: if (!filter) {
On 2015/10/12 16:43:32, robertphillips wrote:
> Just return this with offset set to 0,0 ?

Will update dox to say out-params are undefined if we fail/return null

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage_Gpu.c...
src/image/SkImage_Gpu.cpp:244: return new SkImage_Gpu(dst.width(), dst.height(),
kNeedNewImageUniqueID, info.alphaType(),
On 2015/10/12 16:43:32, robertphillips wrote:
> unbudgeted ?

Don't know how to choose.

[reed1, 2015-10-12 17:53:37]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-12 17:53:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390913005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390913005/80001

[commit-bot: I haz the power, 2015-10-12 17:56:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 17:56:37]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[reed1, 2015-10-12 18:02:19]

ptal

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp
File gm/spritebitmap.cpp (right):

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp#new...
gm/spritebitmap.cpp:125: SkPaint paint;
On 2015/10/12 16:43:32, robertphillips wrote:
> sk_tool_utils::color_to_565 ?

Done.

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp#new...
gm/spritebitmap.cpp:169: 
On 2015/10/12 16:43:32, robertphillips wrote:
> put "offset1.setZero();" on its own line or use "= { 0, 0 }" ?

Done.

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp#new...
gm/spritebitmap.cpp:176: show_image(canvas, image0, SkIPoint::Make(0, 0));
On 2015/10/12 16:43:32, robertphillips wrote:
> 150 -> kImageWHWithPath ?

Done.

https://codereview.chromium.org/1390913005/diff/60001/gm/spritebitmap.cpp#new...
gm/spritebitmap.cpp:181: {
On 2015/10/12 16:43:32, robertphillips wrote:
> // draw with old paths (drawSprite & drawImage w/ filter) for comparison ?

Done.

https://codereview.chromium.org/1390913005/diff/60001/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/1390913005/diff/60001/include/core/SkImage.h#...
include/core/SkImage.h:312: *
On 2015/10/12 16:43:32, robertphillips wrote:
> need -> needed

Done.

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage.cpp
File src/image/SkImage.cpp (right):

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage.cpp#n...
src/image/SkImage.cpp:77: if (!offset) {
On 2015/10/12 16:43:32, robertphillips wrote:
> init offsetStorage to 0,0 here ?

Not needed.

https://codereview.chromium.org/1390913005/diff/60001/src/image/SkImage.cpp#n...
src/image/SkImage.cpp:87: 
On 2015/10/12 16:43:32, robertphillips wrote:
> const SkIRect& srcBounds ?

Done.

[reed1, 2015-10-12 18:02:24]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-10-12 18:02:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390913005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390913005/100001

[commit-bot: I haz the power, 2015-10-12 18:02:40]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-10-13 00:02 UTC

[reed1, 2015-10-12 18:05:22]

The CQ bit was unchecked by reed@google.com

[reed1, 2015-10-12 18:22:43]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-10-12 18:22:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390913005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390913005/120001

[reed1, 2015-10-12 18:23:06]

refreshed w/ tweak to gm

[robertphillips, 2015-10-12 18:27:30]

lgtm

https://codereview.chromium.org/1390913005/diff/100001/include/core/SkImageFi...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1390913005/diff/100001/include/core/SkImageFi...
include/core/SkImageFilter.h:117: bool filterImage(const SkImageFilter*, const
SkBitmap& src, const SkImageFilter::Context&,
line this up ?

https://codereview.chromium.org/1390913005/diff/100001/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/1390913005/diff/100001/src/image/SkImage_Gpu....
src/image/SkImage_Gpu.cpp:188: 
Why do we need SkBitmapDevice.h ?

https://codereview.chromium.org/1390913005/diff/100001/src/image/SkImage_Gpu....
src/image/SkImage_Gpu.cpp:229: 
GrWrapTextureInBitmap ?

[commit-bot: I haz the power, 2015-10-12 18:30:09]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/88d064d0e481949184305c7b1d6b282dddffac39

[reed1, 2015-10-12 18:43:28]

https://codereview.chromium.org/1390913005/diff/100001/include/core/SkImageFi...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1390913005/diff/100001/include/core/SkImageFi...
include/core/SkImageFilter.h:117: bool filterImage(const SkImageFilter*, const
SkBitmap& src, const SkImageFilter::Context&,
On 2015/10/12 18:27:30, robertphillips wrote:
> line this up ?

Done.

https://codereview.chromium.org/1390913005/diff/100001/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/1390913005/diff/100001/src/image/SkImage_Gpu....
src/image/SkImage_Gpu.cpp:188: 
On 2015/10/12 18:27:30, robertphillips wrote:
> Why do we need SkBitmapDevice.h ?

Done.

https://codereview.chromium.org/1390913005/diff/100001/src/image/SkImage_Gpu....
src/image/SkImage_Gpu.cpp:229: 
On 2015/10/12 18:27:30, robertphillips wrote:
> GrWrapTextureInBitmap ?

Done.

[reed1, 2015-10-12 18:43:53]

oops, landed before I could up load last set of tweaks. Will land on top of this
one.

[Stephen White, 2015-10-14 19:22:22]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2015-10-14 19:22:23]

https://codereview.chromium.org/1390913005/diff/120001/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/1390913005/diff/120001/src/image/SkImage_Gpu....
src/image/SkImage_Gpu.cpp:243: if (filter->filterImageGPU(&proxy, src, ctx,
&dst, offsetResult)) {
I'm not 100% certain, but I think if you call filter->filterImage() instead of
filterImageGPU() here, it should work for all cases, and you can remove the
canFilterImageGPU() check above. That'll give the proxy a chance at calling
filter->filterImageGPU() for you (via SkGpuDevice::filterImage()), and fall back
to the generic filter->filterImage() path if not.