[Android] Suppress unnecessary selection updates.

Suppress unnecessary selection updates.


BUG=229812

[Fredrik Öhrn, 2013-04-10 09:21:16]

The mPendingUpdate flag inhibits calling updateSelection() after endBatchEdit()
unless a setEditableText() call was received during the batch edit session.

The update should be harmless, but it triggers SwftKey to start polling the text
which seems to interact badly with the updates coming back from the render
process in response to the changes just SwiftKey made.

Since the session only contained changes initiated by the keyboard, it already
knows the state thus it's safe to inhibit the update.

In addition this patch puts conditions around the setSelection() and
setComposingRegion() calls in setEditableText(), this avoids some unnecessary
batch edit sessions initiated by BaseInputConnection.

[aurimas (slooooooooow), 2013-04-10 14:35:45]

https://chromiumcodereview.appspot.com/13909003/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java
(right):

https://chromiumcodereview.appspot.com/13909003/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:577:
if (mLastUpdateSelectionStart == selectionStart &&
Can you explain why this if check for the last update would allow sending an
update though if we did not receive any setEditableText()?

[Fredrik Öhrn, 2013-04-10 15:27:36]

https://chromiumcodereview.appspot.com/13909003/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java
(right):

https://chromiumcodereview.appspot.com/13909003/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:577:
if (mLastUpdateSelectionStart == selectionStart &&
On 2013/04/10 14:35:46, aurimas wrote:
> Can you explain why this if check for the last update would allow sending an
> update though if we did not receive any setEditableText()? 

When setIgnoreTextInputStateUpdates(false) calls this function the test will not
match if the on screen keyboard changed the selection or composition ranges
during the batch edit.

[aurimas (slooooooooow), 2013-04-10 15:49:12]

https://chromiumcodereview.appspot.com/13909003/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java
(right):

https://chromiumcodereview.appspot.com/13909003/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java:577:
if (mLastUpdateSelectionStart == selectionStart &&
On 2013/04/10 15:27:36, Fredrik Öhrn wrote:
> On 2013/04/10 14:35:46, aurimas wrote:
> > Can you explain why this if check for the last update would allow sending an
> > update though if we did not receive any setEditableText()? 
> 
> When setIgnoreTextInputStateUpdates(false) calls this function the test will
not
> match if the on screen keyboard changed the selection or composition ranges
> during the batch edit.

If the keyboard did change the selection or composition ranges, then why
wouldn't we want to send an update?