Issue 13909002: drive: Supports shared-with-me search in searchDriveMetadata().

Issue 13909002: drive: Supports shared-with-me search in searchDriveMetadata(). (Closed)

Created:
7 years, 8 months ago by Haruki Sato

Modified:
7 years, 8 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Supports shared-with-me search in searchDriveMetadata(). Adds a new option SHARED_WITH_ME, which traverses the tree and return only the entries - with "shared-with-me" label - which has non-"shared-with-me" parent BUG=224186 TEST=unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193342

Patch Set 1 : #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -17 lines)			Patch
M	chrome/browser/chromeos/drive/drive_file_system_interface.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/search_metadata.cc	View	1 2	3 chunks	+41 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/drive/search_metadata_unittest.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	chrome/test/data/chromeos/gdata/root_feed.json	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yoshiki

lgtm with nits https://codereview.chromium.org/13909002/diff/9018/chrome/browser/chromeos/drive/drive_file_system_interface.h File chrome/browser/chromeos/drive/drive_file_system_interface.h (right): https://codereview.chromium.org/13909002/diff/9018/chrome/browser/chromeos/drive/drive_file_system_interface.h#newcode129 chrome/browser/chromeos/drive/drive_file_system_interface.h:129: // TODO(haruki): Add option for shared_with_me ...

7 years, 8 months ago (2013-04-10 04:29:49 UTC) #2

Haruki Sato

https://codereview.chromium.org/13909002/diff/9018/chrome/browser/chromeos/drive/drive_file_system_interface.h File chrome/browser/chromeos/drive/drive_file_system_interface.h (right): https://codereview.chromium.org/13909002/diff/9018/chrome/browser/chromeos/drive/drive_file_system_interface.h#newcode129 chrome/browser/chromeos/drive/drive_file_system_interface.h:129: // TODO(haruki): Add option for shared_with_me and offline. On ...

7 years, 8 months ago (2013-04-10 04:51:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/13909002/17005

7 years, 8 months ago (2013-04-10 04:51:43 UTC) #4

Message was sent while issue was closed.

Change committed as 193342

Expand Messages | Collapse Messages