Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1390893003: Remove ToObject on elements from Array.prototype.toLocaleString() (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove ToObject on elements from Array.prototype.toLocaleString() In ES5, ToObject was called on elements before invoking the .toLocaleString() method on them. ES2015 specifies that ToObject is not called. A test262 test verifies this change. This patch implements the new ES2015 behavior. It is verified by the test262 test built-ins/Array/prototype/toLocaleString/primitive_this_value_getter R=adamk Committed: https://crrev.com/80aa6a5f7f9d49365657bf64a78bf0f5e5918b99 Cr-Commit-Position: refs/heads/master@{#31160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/array.js View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390893003/1
5 years, 2 months ago (2015-10-07 01:26:35 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 01:51:51 UTC) #4
Dan Ehrenberg
5 years, 2 months ago (2015-10-07 17:01:01 UTC) #5
adamk
lgtm
5 years, 2 months ago (2015-10-07 18:16:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390893003/1
5 years, 2 months ago (2015-10-07 18:17:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 18:19:01 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 18:19:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80aa6a5f7f9d49365657bf64a78bf0f5e5918b99
Cr-Commit-Position: refs/heads/master@{#31160}

Powered by Google App Engine
This is Rietveld 408576698