Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1390883007: ButtonCompat: handle missing StateListAnimator gracefully. (Closed)

Created:
5 years, 2 months ago by newt (away)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ButtonCompat: handle missing StateListAnimator gracefully. ButtonCompat can crash on custom ROMs, when using a framework like Xposed, and potentially on future versions of Android, because it assumes that the Widget.Material.Button style contains a stateListAnimator attribute. This is actually a dangerous assumption, since a future version of Android could change Widget.Material.Button. This CL handles this situation gracefully by simply not using a StateListAnimator on the button if Widget.Material.Button doesn't contain a stateListAnimator attribute. BUG=525511 Committed: https://crrev.com/399439d551c3bd915fe180b8c0f3f8e0078623b5 Cr-Commit-Position: refs/heads/master@{#353454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ui/android/java/src/org/chromium/ui/widget/ButtonCompat.java View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 2 months ago (2015-10-09 18:53:21 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 2 months ago (2015-10-10 00:46:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390883007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390883007/1
5 years, 2 months ago (2015-10-10 00:47:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-10 02:09:06 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-10 02:09:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/399439d551c3bd915fe180b8c0f3f8e0078623b5
Cr-Commit-Position: refs/heads/master@{#353454}

Powered by Google App Engine
This is Rietveld 408576698