Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: pkg/analysis_server/lib/src/server/driver.dart

Issue 1390843002: Turn on the new task model by default in analysis server. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/integration/integration_tests.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/server/driver.dart
diff --git a/pkg/analysis_server/lib/src/server/driver.dart b/pkg/analysis_server/lib/src/server/driver.dart
index c5eb6bf65526fde5f7d1684735eae2d2cb610de3..883f50c4e27a000218a1512cd48ac3ce0bd2ca39 100644
--- a/pkg/analysis_server/lib/src/server/driver.dart
+++ b/pkg/analysis_server/lib/src/server/driver.dart
@@ -206,6 +206,11 @@ class Driver implements ServerStarter {
static const String CLIENT_VERSION = "client-version";
/**
+ * The name of the option used to disable the use of the new task model.
+ */
+ static const String DISABLE_NEW_TASK_MODEL = "disable-new-task-model";
+
+ /**
* The name of the option used to enable incremental resolution of API
* changes.
*/
@@ -218,11 +223,6 @@ class Driver implements ServerStarter {
static const String ENABLE_INSTRUMENTATION_OPTION = "enable-instrumentation";
/**
- * The name of the option used to enable the use of the new task model.
- */
- static const String ENABLE_NEW_TASK_MODEL = "enable-new-task-model";
-
- /**
* The name of the option used to set the file read mode.
*/
static const String FILE_READ_MODE = "file-read-mode";
@@ -395,9 +395,7 @@ class Driver implements ServerStarter {
//
// Enable the new task model, if appropriate.
//
- if (results[ENABLE_NEW_TASK_MODEL]) {
- AnalysisEngine.instance.useTaskModel = true;
- }
+ AnalysisEngine.instance.useTaskModel = !results[DISABLE_NEW_TASK_MODEL];
//
// Process all of the plugins so that extensions are registered.
//
@@ -470,6 +468,11 @@ class Driver implements ServerStarter {
parser.addOption(CLIENT_ID,
help: "an identifier used to identify the client");
parser.addOption(CLIENT_VERSION, help: "the version of the client");
+ parser.addFlag(DISABLE_NEW_TASK_MODEL,
+ help: "disable the use of the new task model",
+ defaultsTo: false,
+ hide: true,
+ negatable: false);
parser.addFlag(ENABLE_INCREMENTAL_RESOLUTION_API,
help: "enable using incremental resolution for API changes",
defaultsTo: false,
@@ -478,11 +481,6 @@ class Driver implements ServerStarter {
help: "enable sending instrumentation information to a server",
defaultsTo: false,
negatable: false);
- parser.addFlag(ENABLE_NEW_TASK_MODEL,
- help: "enable the use of the new task model",
- defaultsTo: false,
- hide: true,
- negatable: false);
parser.addFlag(HELP_OPTION,
help: "print this help message without starting a server",
defaultsTo: false,
« no previous file with comments | « no previous file | pkg/analysis_server/test/integration/integration_tests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698