Ensure Android RunSymmetric test can select the AudioRecord path.

Ensure Android RunSymmetric test can select the AudioRecord path.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245223

[henrika (OOO until Aug 14), 2014-01-15 10:08:57]

LGTM assuming that
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...
is OK.

Also, can you just summarize how it works now. What does /0 and /1 correspond
to? If a device is not listed as "supports EC", then what? Will /1 <=>
AudioRecord anyhow?

[henrika (OOO until Aug 14), 2014-01-15 10:09:12]

https://codereview.chromium.org/139083002/diff/20001/media/audio/android/audi...
File media/audio/android/audio_manager_android.cc (right):

https://codereview.chromium.org/139083002/diff/20001/media/audio/android/audi...
media/audio/android/audio_manager_android.cc:213: if
(!SetAudioDevice(device_id)) {
Thanks.

[ajm, 2014-01-16 01:04:43]

On 2014/01/15 10:08:57, henrika wrote:
> LGTM assuming that
>
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...
> is OK.

Yeah, that was a flaky timeout on
AudioAndroidInputTest/AudioAndroidInputTest.StartInputStreamCallbacksNonDefaultParameters/0
that I've seen a few times now.

> 
> Also, can you just summarize how it works now. What does /0 and /1 correspond
> to? If a device is not listed as "supports EC", then what? Will /1 <=>
> AudioRecord anyhow?

/0 and /1 correspond to entries in a bool vector which parameterizes the test:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/androi...
0 -> false
1 -> true

The false run results in NO_EFFECTS and the true run results in ECHO_CANCELLER:
https://code.google.com/p/chromium/codesearch#chromium/src/media/audio/androi...
NO_EFFECTS -> OpenSLES path
ECHO_CANCELLER -> AudioRecord path

so,
/0 -> OpenSLES path
/1 -> AudioRecord path


There is a check on acousticEchoCanceler.isAvailable() in the AudioRecordInput.
As a result, we can force the AudioRecord path even on devices lacking platform
AEC, as the ECHO_CANCELLER setting will simply be ignored:
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android...

[commit-bot: I haz the power, 2014-01-16 06:45:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajm@chromium.org/139083002/20001

[henrika (OOO until Aug 14), 2014-01-16 08:02:20]

Thanks, got it now.

[commit-bot: I haz the power, 2014-01-16 17:18:36]

Change committed as 245223