Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1390803002: Move dart:_vmservice native entries into bootstrap natives (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move dart:_vmservice native entries into bootstrap natives With this CL the dart:_vmservice library is made regular with respect to other dart: builtin libraries. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/150e8d2757e8cc18bf87c3d7b50f914da97c59a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -229 lines) Patch
A runtime/lib/vmservice.cc View 1 chunk +149 lines, -0 lines 0 comments Download
M runtime/lib/vmservice_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/bootstrap_natives.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/service_isolate.h View 3 chunks +2 lines, -5 lines 0 comments Download
M runtime/vm/service_isolate.cc View 3 chunks +22 lines, -220 lines 0 comments Download
M runtime/vm/vm.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 2 months ago (2015-10-06 16:12:09 UTC) #2
rmacnak
lgtm
5 years, 2 months ago (2015-10-06 16:13:33 UTC) #3
Cutch
5 years, 2 months ago (2015-10-06 16:16:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
150e8d2757e8cc18bf87c3d7b50f914da97c59a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698