Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: client/tests/isolated_format_test.py

Issue 1390773002: Add an assert to ensure UTF-8 locale when handling file paths. (Closed) Base URL: git@github.com:luci/luci-py.git@master
Patch Set: More fixes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tests/isolate_test.py ('k') | client/tests/isolateserver_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tests/isolated_format_test.py
diff --git a/client/tests/isolated_format_test.py b/client/tests/isolated_format_test.py
index e6166462a0f52a42a9c8f900df9ef1a44e144710..099a1b724436b6f6fb9617cd6f510da88cae239c 100755
--- a/client/tests/isolated_format_test.py
+++ b/client/tests/isolated_format_test.py
@@ -7,7 +7,6 @@ import hashlib
import json
import logging
import os
-import shutil
import sys
import tempfile
import unittest
@@ -17,6 +16,8 @@ import net_utils
import isolated_format
from depot_tools import auto_stub
+from depot_tools import fix_encoding
+from utils import file_path
from utils import tools
import isolateserver_mock
@@ -44,7 +45,7 @@ class SymlinkTest(unittest.TestCase):
def tearDown(self):
try:
os.chdir(self.old_cwd)
- shutil.rmtree(self.cwd)
+ file_path.rmtree(self.cwd)
finally:
super(SymlinkTest, self).tearDown()
@@ -240,6 +241,7 @@ class TestIsolated(auto_stub.TestCase):
if __name__ == '__main__':
+ fix_encoding.fix_encoding()
if '-v' in sys.argv:
unittest.TestCase.maxDiff = None
logging.basicConfig(
« no previous file with comments | « client/tests/isolate_test.py ('k') | client/tests/isolateserver_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698