Support optimistic Create and Write operations on the SimpleCache.

net/disk_cache/cache_creator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/metrics/field_trial.h"
 #include "base/stringprintf.h"
 #include "net/base/net_errors.h"
 #include "net/disk_cache/backend_impl.h"
 #include "net/disk_cache/cache_util.h"
@@ skipping 63 matching lines @@
 
 CacheCreator::~CacheCreator() {
 }
 
 int CacheCreator::Run() {
   // TODO(pasko): The two caches should never coexist on disk. Each individual
   // cache backend should fail to initialize if it observes the index that does
   // not belong to it.
   const std::string experiment_name =
       base::FieldTrialList::FindFullName("SimpleCacheTrial");
+
+  if (type_ == net::DISK_CACHE) {

[pasko-google - do not use, 2013/05/02 15:29:35]

I thought you would change this in a separate CL, I just ran tests with this CL
patched in, and could not figure out why some of the tests failed.

In future please do not add changes to the CL that reviewers should not be
agreeing with. This makes things complicated and unexpected.

[gavinp, 2013/05/02 15:32:40]

I recommended he do this; I thought it would be nice to share the results with
the reviewers. I know I'm interested in them.

Is it so bad if the patch set is named appropriately?

[pasko-google - do not use, 2013/05/02 15:35:55]

sry, I normally do not look at patch set names, probably a good time to start
doing that

+    disk_cache::SimpleBackendImpl* simple_cache =
+        new disk_cache::SimpleBackendImpl(path_, max_bytes_, type_, thread_,
+                                            net_log_);
+    created_cache_ = simple_cache;
+    return simple_cache->Init(
+        base::Bind(&CacheCreator::OnIOComplete, base::Unretained(this)));
+  }
+
   if (experiment_name == "ExplicitYes" || experiment_name == "ExperimentYes" ||
       experiment_name == "ExperimentYes2") {
     // TODO(gavinp,pasko): While simple backend development proceeds, we're only
     // testing it against net::DISK_CACHE. Turn it on for more cache types as
     // appropriate.
     if (type_ == net::DISK_CACHE) {
       disk_cache::SimpleBackendImpl* simple_cache =
           new disk_cache::SimpleBackendImpl(path_, max_bytes_, type_, thread_,
                                             net_log_);
       created_cache_ = simple_cache;
@@ skipping 64 matching lines @@
     *backend = disk_cache::MemBackendImpl::CreateBackend(max_bytes, net_log);
     return *backend ? net::OK : net::ERR_FAILED;
   }
   DCHECK(thread);
   CacheCreator* creator = new CacheCreator(path, force, max_bytes, type, kNone,
                                            thread, net_log, backend, callback);
   return creator->Run();
 }
 
 }  // namespace disk_cache