Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1390673002: Merge to XFA: Disable JBIG2 cache; prevent data corruption - try 2. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
jbreiden, Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Disable JBIG2 cache; prevent data corruption - try 2. Also change CJBig2_SymbolDict::DeepCopy() to return a unique_ptr to prevent a potential leak if the cache size was 0. BUG=pdfium:207 R=tsepez@chromium.org, jbreiden@google.com Review URL: https://codereview.chromium.org/1374633004 . (cherry picked from commit fd12ec5584d9a17f310a2c0c408a438ef3b1ce63) Committed: https://pdfium.googlesource.com/pdfium/+/1b1dd8a6907f4631044b1c03698170853af594a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M core/src/fxcodec/jbig2/JBig2_Context.cpp View 3 chunks +10 lines, -3 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.h View 2 chunks +9 lines, -6 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.cpp View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
TBR, clean merge.
5 years, 2 months ago (2015-10-06 00:09:08 UTC) #1
Lei Zhang
5 years, 2 months ago (2015-10-06 00:09:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b1dd8a6907f4631044b1c03698170853af594a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698