Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1357)

Unified Diff: build/android/PRESUBMIT.py

Issue 1390613002: Revert of [Android] Add a configurable environment for devil/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/buildbot/bb_device_status_check.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/PRESUBMIT.py
diff --git a/build/android/PRESUBMIT.py b/build/android/PRESUBMIT.py
index d7a3ae163874dd9538425e7cd6b2f50649b3d5d9..a75bf943312266ed9b700c766ec757947a4961ac 100644
--- a/build/android/PRESUBMIT.py
+++ b/build/android/PRESUBMIT.py
@@ -12,12 +12,9 @@
def CommonChecks(input_api, output_api):
output = []
- build_android_dir = input_api.PresubmitLocalPath()
- chromium_src_dir = input_api.os_path.join(build_android_dir, '..', '..')
-
def J(*dirs):
"""Returns a path relative to presubmit directory."""
- return input_api.os_path.join(build_android_dir, *dirs)
+ return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)
build_pys = [
r'gyp/.*\.py$',
@@ -43,7 +40,7 @@
pylib_test_env = dict(input_api.environ)
pylib_test_env.update({
- 'PYTHONPATH': build_android_dir,
+ 'PYTHONPATH': input_api.PresubmitLocalPath(),
'PYTHONDONTWRITEBYTECODE': '1',
})
output.extend(input_api.canned_checks.RunUnitTests(
@@ -51,6 +48,11 @@
output_api,
unit_tests=[
J('.', 'emma_coverage_stats_test.py'),
+ J('devil', 'android', 'battery_utils_test.py'),
+ J('devil', 'android', 'device_utils_test.py'),
+ J('devil', 'android', 'md5sum_test.py'),
+ J('devil', 'android', 'logcat_monitor_test.py'),
+ J('devil', 'utils', 'timeout_retry_unittest.py'),
J('gyp', 'util', 'md5_check_test.py'),
J('pylib', 'base', 'test_dispatcher_unittest.py'),
J('pylib', 'gtest', 'gtest_test_instance_test.py'),
@@ -59,26 +61,6 @@
J('pylib', 'results', 'json_results_test.py'),
],
env=pylib_test_env))
-
-
- devil_test_env = dict(pylib_test_env)
- devil_test_env.update({
- 'DEVIL_BINARY_DIR':
- input_api.os_path.join(chromium_src_dir, 'output', 'directory'),
- 'DEVIL_PYMOCK_PATH':
- input_api.os_path.join(chromium_src_dir, 'third_party', 'pymock')
- })
- output.extend(input_api.canned_checks.RunUnitTests(
- input_api,
- output_api,
- unit_tests=[
- J('devil', 'android', 'battery_utils_test.py'),
- J('devil', 'android', 'device_utils_test.py'),
- J('devil', 'android', 'md5sum_test.py'),
- J('devil', 'android', 'logcat_monitor_test.py'),
- J('devil', 'utils', 'timeout_retry_unittest.py'),
- ],
- env=devil_test_env))
return output
« no previous file with comments | « no previous file | build/android/buildbot/bb_device_status_check.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698