Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1390613002: Revert of [Android] Add a configurable environment for devil/. (Closed)

Created:
5 years, 2 months ago by jbudorick
Modified:
5 years, 2 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, nednguyen, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add a configurable environment for devil/. (patchset #12 id:220001 of https://codereview.chromium.org/1316413003/ ) Reason for revert: breaks on non-default output directories. Original issue's description: > [Android] Add a configurable environment for devil/. > > BUG=476719 > > Committed: https://crrev.com/975fc02186d195c3baf6f0380fed06433c636670 > Cr-Commit-Position: refs/heads/master@{#352359} TBR=aiolos@chromium.org,mikecase@chromium.org,nednguyen@google.com,perezju@chromium.org,rnephew@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476719 Committed: https://crrev.com/f7280993a941acd40628664d108d7a7ed36be17e Cr-Commit-Position: refs/heads/master@{#352436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -349 lines) Patch
M build/android/PRESUBMIT.py View 4 chunks +7 lines, -25 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/devil/android/apk_helper.py View 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/devil/android/battery_utils_test.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/android/devil/android/device_temp_file_test.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/devil/android/device_utils.py View 3 chunks +2 lines, -2 lines 0 comments Download
M build/android/devil/android/device_utils_test.py View 3 chunks +16 lines, -18 lines 0 comments Download
M build/android/devil/android/logcat_monitor_test.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/devil/android/md5sum.py View 3 chunks +4 lines, -3 lines 0 comments Download
M build/android/devil/android/md5sum_test.py View 1 chunk +8 lines, -12 lines 0 comments Download
M build/android/devil/android/sdk/aapt.py View 2 chunks +3 lines, -5 lines 0 comments Download
M build/android/devil/android/sdk/adb_wrapper.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/devil/android/sdk/dexdump.py View 1 chunk +2 lines, -3 lines 0 comments Download
M build/android/devil/android/sdk/shared_prefs_test.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/devil/android/sdk/split_select.py View 2 chunks +3 lines, -4 lines 0 comments Download
D build/android/devil/devil_env.py View 1 chunk +0 lines, -159 lines 0 comments Download
M build/android/devil/utils/lsusb.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/devil/utils/mock_calls.py View 1 chunk +4 lines, -2 lines 0 comments Download
M build/android/devil/utils/mock_calls_test.py View 1 chunk +3 lines, -2 lines 0 comments Download
D build/android/devil_config.json View 1 chunk +0 lines, -63 lines 0 comments Download
M build/android/provision_devices.py View 2 chunks +0 lines, -3 lines 0 comments Download
M build/android/pylib/forwarder.py View 4 chunks +6 lines, -6 lines 0 comments Download
M build/android/pylib/perf/test_runner.py View 2 chunks +0 lines, -2 lines 0 comments Download
M build/android/pylintrc View 1 chunk +0 lines, -4 lines 0 comments Download
M build/android/test_runner.py View 3 chunks +0 lines, -21 lines 0 comments Download
M tools/telemetry/catapult_base/dependency_manager/dependency_manager.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android] Add a configurable environment for devil/.
5 years, 2 months ago (2015-10-05 21:41:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390613002/1
5 years, 2 months ago (2015-10-05 21:41:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 21:43:57 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 21:45:27 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f7280993a941acd40628664d108d7a7ed36be17e
Cr-Commit-Position: refs/heads/master@{#352436}

Powered by Google App Engine
This is Rietveld 408576698