Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1390533003: Update co19 test suite to commit Oct 1 2015 1d96fbbf94c534c9076f90bd4ebce6226169da48 (Closed)

Created:
5 years, 2 months ago by Bill Hesse
Modified:
5 years, 1 month ago
Reviewers:
ricow1, Søren Gjesse
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update co19 test suite to commit Oct 1 2015 1d96fbbf94c534c9076f90bd4ebce6226169da48 Update co19-co19.status Update co19 to tot. Rename co19 language tests in status files, and roll co19 version. BUG= R=ricow@google.com, sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/d524cf407629e37263bc6aa8b17098bd465806fa

Patch Set 1 #

Patch Set 2 : Update status files for platforms, based on testing. #

Patch Set 3 : Add "Please triage" note to co19-analyzer2.status. #

Total comments: 1

Patch Set 4 : Undo debug edits to script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1271 lines, -1033 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-analyzer.status View 5 chunks +36 lines, -37 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 2 5 chunks +140 lines, -59 lines 0 comments Download
M tests/co19/co19-co19.status View 1 2 chunks +3 lines, -4 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 7 chunks +176 lines, -66 lines 0 comments Download
M tests/co19/co19-dartium.status View 1 13 chunks +844 lines, -849 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 3 chunks +70 lines, -16 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Bill Hesse
5 years, 1 month ago (2015-11-10 16:50:50 UTC) #2
ricow1
lgtm https://codereview.chromium.org/1390533003/diff/40001/tools/testing/dart/co19_test.dart File tools/testing/dart/co19_test.dart (right): https://codereview.chromium.org/1390533003/diff/40001/tools/testing/dart/co19_test.dart#newcode29 tools/testing/dart/co19_test.dart:29: // const <String>['-mrelease,debug', '-rvm', '-cnone'], debug edit?
5 years, 1 month ago (2015-11-11 06:27:48 UTC) #4
Søren Gjesse
lgtm
5 years, 1 month ago (2015-11-11 07:40:55 UTC) #5
Bill Hesse
5 years, 1 month ago (2015-11-11 09:47:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
d524cf407629e37263bc6aa8b17098bd465806fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698