Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1390533002: MIPS64: Fix Add CallRuntime support to the interpreter. (Closed)

Created:
5 years, 2 months ago by dusan.milosavljevic
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix Add CallRuntime support to the interpreter. TEST=cctest/test-interpreter/InterpreterCall, cctest/test-bytecode-generator/CallRuntime BUG=v8:4280 LOG=N Committed: https://crrev.com/d5e6ab9e08e1454aebcc80caaf76263801fb83d1 Cr-Commit-Position: refs/heads/master@{#31106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/mips64/builtins-mips64.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dusan.milosavljevic
PTAL.
5 years, 2 months ago (2015-10-05 15:02:58 UTC) #2
rmcilroy
Oops not sure how I broke this, I was only meaning to move the function. ...
5 years, 2 months ago (2015-10-05 16:04:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390533002/1
5 years, 2 months ago (2015-10-05 16:20:58 UTC) #5
paul.l...
LGTM, thanks Dusan!
5 years, 2 months ago (2015-10-05 16:21:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 16:45:00 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 16:45:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5e6ab9e08e1454aebcc80caaf76263801fb83d1
Cr-Commit-Position: refs/heads/master@{#31106}

Powered by Google App Engine
This is Rietveld 408576698