Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chromeos/display/output_configurator.cc

Issue 139053003: Chrome OS: avoid suspending on lid close when casting is active. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address nits from sergeyu, derat. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/display/output_configurator.cc
diff --git a/chromeos/display/output_configurator.cc b/chromeos/display/output_configurator.cc
index fb545aaf7cb45720c94884524486f5cdce3374a5..46191a9f2d9ea8e219787d826935d3675bf9fd4d 100644
--- a/chromeos/display/output_configurator.cc
+++ b/chromeos/display/output_configurator.cc
@@ -106,20 +106,6 @@ int GetOutputPower(
return num_on_outputs;
}
-// Determine if there is an "internal" output and how many outputs are
-// connected.
-bool IsProjecting(
- const std::vector<OutputConfigurator::OutputSnapshot>& outputs) {
- bool has_internal_output = false;
- int connected_output_count = outputs.size();
- for (size_t i = 0; i < outputs.size(); ++i)
- has_internal_output |= outputs[i].type == OUTPUT_TYPE_INTERNAL;
-
- // "Projecting" is defined as having more than 1 output connected while at
- // least one of them is an internal output.
- return has_internal_output && (connected_output_count > 1);
-}
-
} // namespace
OutputConfigurator::ModeInfo::ModeInfo()
@@ -252,7 +238,8 @@ OutputConfigurator::OutputConfigurator()
xrandr_event_base_(0),
output_state_(STATE_INVALID),
power_state_(DISPLAY_POWER_ALL_ON),
- next_output_protection_client_id_(1) {
+ next_output_protection_client_id_(1),
+ casting_session_count_(0) {
}
OutputConfigurator::~OutputConfigurator() {}
@@ -294,7 +281,7 @@ void OutputConfigurator::Start(uint32 background_color_argb) {
// that all displays are on when signing out.
delegate_->ForceDPMSOn();
delegate_->UngrabServer();
- delegate_->SendProjectingStateToPowerManager(IsProjecting(cached_outputs_));
+ SendProjectingStateToPowerManager();
NotifyObservers(success, new_state);
}
@@ -335,6 +322,22 @@ bool OutputConfigurator::ApplyProtections(const DisplayProtections& requests) {
return true;
}
+void OutputConfigurator::SendProjectingStateToPowerManager() {
+ bool has_internal_output = false;
+ int connected_output_count = cached_outputs_.size() + casting_session_count_;
+ for (size_t i = 0; i < cached_outputs_.size(); ++i) {
+ if (cached_outputs_[i].type == OUTPUT_TYPE_INTERNAL) {
+ has_internal_output = true;
+ break;
+ }
+ }
+
+ // "Projecting" is defined as having more than 1 output connected while at
+ // least one of them is an internal output.
+ bool is_projecting = has_internal_output && (connected_output_count > 1);
+ delegate_->SendProjectingStateToPowerManager(is_projecting);
+}
+
OutputConfigurator::OutputProtectionClientId
OutputConfigurator::RegisterOutputProtectionClient() {
if (!configure_display_)
@@ -599,6 +602,16 @@ base::EventStatus OutputConfigurator::WillProcessEvent(
void OutputConfigurator::DidProcessEvent(const base::NativeEvent& event) {
}
+void OutputConfigurator::OnCastingSessionStartedOrStopped(bool started) {
+ if (started) {
+ ++casting_session_count_;
+ } else {
+ DCHECK_GT(casting_session_count_, 0);
+ --casting_session_count_;
oshima 2014/01/17 20:57:36 nit: you may want to reset to 0 if it goes blow 0
hshi1 2014/01/17 21:01:37 Done.
+ }
+ SendProjectingStateToPowerManager();
+}
+
void OutputConfigurator::AddObserver(Observer* observer) {
observers_.AddObserver(observer);
}
@@ -777,7 +790,7 @@ void OutputConfigurator::ConfigureOutputs() {
delegate_->UngrabServer();
NotifyObservers(success, new_state);
- delegate_->SendProjectingStateToPowerManager(IsProjecting(cached_outputs_));
+ SendProjectingStateToPowerManager();
}
void OutputConfigurator::NotifyObservers(bool success,

Powered by Google App Engine
This is Rietveld 408576698