gm/bigtileimagefilter.cpp - Issue 1390523005: factories should return baseclass, allowing the impl to specialize

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/bigtileimagefilter.cpp

Issue 1390523005: factories should return baseclass, allowing the impl to specialize (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/bigtileimagefilter.cpp

diff --git a/gm/bigtileimagefilter.cpp b/gm/bigtileimagefilter.cpp

index 20c462b7449cbecbcb9c399ea1ccc318171c75c5..f2164e8e2fc3d02231b5f31fdfc0da519cf72b91 100644

--- a/gm/bigtileimagefilter.cpp

+++ b/gm/bigtileimagefilter.cpp

@@ -56,7 +56,7 @@ protected:

SkRect bound = SkRect::MakeWH(SkIntToScalar(kWidth), SkIntToScalar(kHeight));

SkAutoTUnref<SkImageFilter> imageSource(SkImageSource::Create(fRedImage));

- SkAutoTUnref<SkTileImageFilter> tif(SkTileImageFilter::Create(

+ SkAutoTUnref<SkImageFilter> tif(SkTileImageFilter::Create(

SkRect::MakeWH(SkIntToScalar(kBitmapSize), SkIntToScalar(kBitmapSize)),

SkRect::MakeWH(SkIntToScalar(kWidth), SkIntToScalar(kHeight)),

imageSource));

@@ -71,7 +71,7 @@ protected:

SkRect bound2 = SkRect::MakeWH(SkIntToScalar(kBitmapSize), SkIntToScalar(kBitmapSize));

- SkAutoTUnref<SkTileImageFilter> tif2(SkTileImageFilter::Create(

+ SkAutoTUnref<SkImageFilter> tif2(SkTileImageFilter::Create(

SkRect::MakeWH(SkIntToScalar(kBitmapSize), SkIntToScalar(kBitmapSize)),

nullptr));

« no previous file with comments | « bench/MorphologyBench.cpp ('k') | gm/filterfastbounds.cpp » ('j') | no next file with comments »