Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1390523005: factories should return baseclass, allowing the impl to specialize (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

factories should return baseclass, allowing the impl to specialize waiting on https://codereview.chromium.org/1386163002/# to land BUG=skia:4424 Committed: https://skia.googlesource.com/skia/+/80a6dcaa1b757826ed7414f64b035d512d9ccbf8

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix comments from #8 #

Patch Set 3 : cleanup more factories #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -126 lines) Patch
M bench/MorphologyBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gm/bigtileimagefilter.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M gm/pictureimagefilter.cpp View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 2 chunks +11 lines, -15 lines 0 comments Download
M include/effects/SkDropShadowImageFilter.h View 2 chunks +10 lines, -10 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 1 2 2 chunks +13 lines, -13 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 1 1 chunk +10 lines, -8 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 2 6 chunks +11 lines, -9 lines 0 comments Download
M include/effects/SkPixelXorXfermode.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M include/effects/SkRectShaderImageFilter.h View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M include/effects/SkTableMaskFilter.h View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M include/effects/SkTileImageFilter.h View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 3 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
reed1
ptal -- clean-up + pre-cl for the localmatrix cl
5 years, 2 months ago (2015-10-05 21:23:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390523005/1
5 years, 2 months ago (2015-10-05 21:23:16 UTC) #4
reed1
Will need a (prior) clean-up CL in chrome/blink. Will prepare that now...
5 years, 2 months ago (2015-10-05 21:23:52 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-05 21:29:23 UTC) #7
robertphillips
lgtm https://codereview.chromium.org/1390523005/diff/1/include/effects/SkOffsetImageFilter.h File include/effects/SkOffsetImageFilter.h (right): https://codereview.chromium.org/1390523005/diff/1/include/effects/SkOffsetImageFilter.h#newcode14 include/effects/SkOffsetImageFilter.h:14: class SK_API SkOffsetImageFilter : public SkImageFilter { Move ...
5 years, 2 months ago (2015-10-06 11:43:12 UTC) #8
reed1
https://codereview.chromium.org/1390523005/diff/1/include/effects/SkOffsetImageFilter.h File include/effects/SkOffsetImageFilter.h (right): https://codereview.chromium.org/1390523005/diff/1/include/effects/SkOffsetImageFilter.h#newcode14 include/effects/SkOffsetImageFilter.h:14: class SK_API SkOffsetImageFilter : public SkImageFilter { On 2015/10/06 ...
5 years, 2 months ago (2015-10-06 16:59:24 UTC) #9
reed1
more factories updated
5 years, 2 months ago (2015-10-06 16:59:48 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390523005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390523005/40001
5 years, 2 months ago (2015-10-06 17:00:04 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390523005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390523005/60001
5 years, 2 months ago (2015-10-06 17:10:02 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-06 17:16:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390523005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390523005/60001
5 years, 2 months ago (2015-10-06 18:11:27 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/80a6dcaa1b757826ed7414f64b035d512d9ccbf8
5 years, 2 months ago (2015-10-06 18:12:27 UTC) #21
Stephen Chennney
5 years, 2 months ago (2015-10-06 19:54:58 UTC) #22
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1389063002/ by schenney@chromium.org.

The reason for reverting is: Breaks Chrome with this link error:
../../third_party/skia/include/effects/SkMorphologyImageFilter.h:75: error:
undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int,
int, SkImageFilter*, SkImageFilter::CropRect const*)'
../../third_party/skia/include/effects/SkMorphologyImageFilter.h:104: error:
undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int,
int, SkImageFilter*, SkImageFilter::CropRect const*)'

Presumably due to code in
third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp that
contains:
#include "SkMorphologyImageFilter.h"

...

    if (m_type == FEMORPHOLOGY_OPERATOR_DILATE)
        return adoptRef(SkDilateImageFilter::Create(radiusX, radiusY,
input.get(), &rect));
    return adoptRef(SkErodeImageFilter::Create(radiusX, radiusY, input.get(),
&rect));
.

Powered by Google App Engine
This is Rietveld 408576698