google_apis/gcm/engine/connection_factory_impl_unittest.cc - Issue 1390513002: Remove base::MessageLoop::{Quit,QuitClosure} functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl_unittest.cc

Issue 1390513002: Remove base::MessageLoop::{Quit,QuitClosure} functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Split into small CLs Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cloud_print/service/win/cloud_print_service_config.cc ('k') | gpu/tools/compositor_model_bench/compositor_model_bench.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/engine/connection_factory_impl_unittest.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl_unittest.cc b/google_apis/gcm/engine/connection_factory_impl_unittest.cc

index 31d907d3fac30fd7c5b4a8fd111fa7fb1b680194..7e8bc02e63f913c27e8c66adbe18707070cf9a81 100644

--- a/google_apis/gcm/engine/connection_factory_impl_unittest.cc

+++ b/google_apis/gcm/engine/connection_factory_impl_unittest.cc

@@ -434,8 +434,7 @@ TEST_F(ConnectionFactoryImplTest, CanarySucceedsRetryDuringLogin) {

// Pump the loop, to ensure the pending backoff retry has no effect.

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

- FROM_HERE,

- base::MessageLoop::QuitClosure(),

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(1));

WaitForConnections();

}