chrome/browser/ui/search/instant_extended_browsertest.cc - Issue 13905008: Merge local_omnibox_popup into local_ntp. Render the Google logo and fakebox if Google is the sear…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/instant_extended_browsertest.cc

Issue 13905008: Merge local_omnibox_popup into local_ntp. Render the Google logo and fakebox if Google is the sear… (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Addressing comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/search/instant_extended_browsertest.cc

diff --git a/chrome/browser/ui/search/instant_extended_browsertest.cc b/chrome/browser/ui/search/instant_extended_browsertest.cc

index 1e24ebc34c7bfc018d6be040a0a692fc3e5e54dc..95d5d138aaa3d1659ccde27314466576eb4e82c0 100644

--- a/chrome/browser/ui/search/instant_extended_browsertest.cc

+++ b/chrome/browser/ui/search/instant_extended_browsertest.cc

@@ -664,7 +664,9 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPIsUsedInSameTab) {

EXPECT_TRUE(chrome::IsInstantNTP(active_tab));

}

-IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPForWrongProvider) {

+// TODO(samarth): re-enable when fixing the infinite reload on shutdown.

+IN_PROC_BROWSER_TEST_F(InstantExtendedTest,

+ DISABLED_PreloadedNTPForWrongProvider) {

// Setup Instant.

ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));

FocusOmniboxAndWaitForInstantExtendedSupport();

« chrome/browser/search/search_unittest.cc ('K') | « chrome/browser/ui/search/instant_controller.cc ('k') | chrome/browser/ui/search/instant_page.h » ('j') | no next file with comments »