Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: chrome/browser/ui/search/instant_controller.h

Issue 13905008: Merge local_omnibox_popup into local_ntp. Render the Google logo and fakebox if Google is the sear… (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Address Samarth's comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_controller.h
diff --git a/chrome/browser/ui/search/instant_controller.h b/chrome/browser/ui/search/instant_controller.h
index 445c80e8356c1981d8ac5443639c067cd0532c78..61b4f26313ed3e182e948228408f23a6f806a18f 100644
--- a/chrome/browser/ui/search/instant_controller.h
+++ b/chrome/browser/ui/search/instant_controller.h
@@ -284,9 +284,9 @@ class InstantController : public InstantPage::Delegate,
// Ensures that |overlay_| uses the Instant URL returned by GetInstantURL(),
// creating a new overlay if necessary. In extended mode, will fallback to
- // using the kLocalOmniboxPopupURL as the Instant URL in case GetInstantURL()
- // returns false. Returns true if an Instant URL could be determined.
- // For |ignore_blacklist| look at comments in GetInstantURL().
+ // using the kChromeSearchLocalNtpUrl as the Instant URL in case
+ // GetInstantURL() returns false. Returns true if an Instant URL could be
+ // determined. For |ignore_blacklist| look at comments in GetInstantURL().
bool EnsureOverlayIsCurrent(bool ignore_blacklist);
// Recreates the |overlay_| with |instant_url|. Note that |overlay_| is
@@ -360,12 +360,6 @@ class InstantController : public InstantPage::Delegate,
// returns false.)
bool FixSuggestion(InstantSuggestion* suggestion) const;
- // Returns true if we should use |instant_tab_| instead of |overlay_| for
- // handling suggestions.
- // TODO(samarth|sreeram): this is brittle. Instead, we should probably just
- // combine the two local pages into one.
- bool UseInstantTabToShowSuggestions() const;
-
// Returns true if we should switch to using the local NTP.
bool ShouldSwitchToLocalNTP() const;
@@ -376,7 +370,7 @@ class InstantController : public InstantPage::Delegate,
const bool extended_enabled_;
bool instant_enabled_;
- // If true, the Instant URL is set to kLocalOmniboxPopupURL.
+ // If true, the Instant URL is set to kChromeSearchLocalNtpUrl.
bool use_local_page_only_;
// The state of the overlay page, i.e., the page owned by |overlay_|. Ignored

Powered by Google App Engine
This is Rietveld 408576698