Merge local_omnibox_popup into local_ntp. Render the Google logo and fakebox if Google is the sear…

chrome/browser/search/search_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/search/search.h"
 #include "chrome/browser/search_engines/template_url_service.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
@@ skipping 170 matching lines @@
 
 class SearchTest : public BrowserWithTestWindowTest {
  protected:
   virtual void SetUp() OVERRIDE {
     BrowserWithTestWindowTest::SetUp();
     TemplateURLServiceFactory::GetInstance()->SetTestingFactoryAndUse(
         profile(), &TemplateURLServiceFactory::BuildInstanceFor);
     TemplateURLService* template_url_service =
         TemplateURLServiceFactory::GetForProfile(profile());
     ui_test_utils::WaitForTemplateURLServiceToLoad(template_url_service);
+    SetSearchProvider(false);
+  }
 
+  void SetSearchProvider(bool isGoogle) {

[sreeram, 2013/04/19 20:30:44]

Nit: is_google
(Yeah, the differing variable naming conventions make it hard when you're
constantly editing both JS and C++.)

[jeremycho, 2013/04/19 20:39:36]

Done.

+    TemplateURLService* template_url_service =
+        TemplateURLServiceFactory::GetForProfile(profile());
     TemplateURLData data;
-    data.SetURL("http://foo.com/url?bar={searchTerms}");
-    data.instant_url = "http://foo.com/instant?"
-        "{google:omniboxStartMarginParameter}foo=foo#foo=foo";
-    data.alternate_urls.push_back("http://foo.com/alt#quux={searchTerms}");
-    data.search_terms_replacement_key = "strk";
-
+    if (isGoogle) {
+      data.SetURL("http://www.google.com/");
+      data.instant_url = "http://www.google.com/";
+    } else {
+      data.SetURL("http://foo.com/url?bar={searchTerms}");
+      data.instant_url = "http://foo.com/instant?"
+          "{google:omniboxStartMarginParameter}foo=foo#foo=foo";
+      data.alternate_urls.push_back("http://foo.com/alt#quux={searchTerms}");
+      data.search_terms_replacement_key = "strk";
+    }
     TemplateURL* template_url = new TemplateURL(profile(), data);
     // Takes ownership of |template_url|.
     template_url_service->Add(template_url);
     template_url_service->SetDefaultSearchProvider(template_url);
   }
 };
 
 struct SearchTestCase {
   const char* url;
   bool expected_result;
@@ skipping 27 matching lines @@
     EXPECT_EQ(test.expected_result,
               ShouldAssignURLToInstantRenderer(GURL(test.url), profile()))
         << test.url << " " << test.comment;
   }
 }
 
 TEST_F(SearchTest, ShouldAssignURLToInstantRendererExtendedEnabled) {
   EnableInstantExtendedAPIForTesting();
 
   const SearchTestCase kTestCases[] = {
-    {chrome::kChromeSearchLocalOmniboxPopupURL, true,  ""},
     {chrome::kChromeSearchLocalNtpUrl, true,  ""},
+    {chrome::kChromeSearchLocalGoogleNtpUrl, true,  ""},
     {"https://foo.com/instant?strk",   true,  ""},
     {"https://foo.com/instant#strk",   true,  ""},
     {"https://foo.com/instant?strk=0", true,  ""},
     {"https://foo.com/url?strk",       true,  ""},
     {"https://foo.com/alt?strk",       true,  ""},
     {"http://foo.com/instant",         false, "Non-HTTPS"},
     {"http://foo.com/instant?strk",    false, "Non-HTTPS"},
     {"http://foo.com/instant?strk=1",  false, "Non-HTTPS"},
     {"https://foo.com/instant",        false, "No search terms replacement"},
     {"https://foo.com/?strk",          false, "Non-exact path"},
@@ skipping 12 matching lines @@
       TemplateURLServiceFactory::GetForProfile(profile())->
           GetDefaultSearchProvider();
   EXPECT_EQ(
       GURL("https://foo.com/dev?bar=bar#bar=bar"),
       CoerceCommandLineURLToTemplateURL(
           GURL("http://myserver.com:9000/dev?bar=bar#bar=bar"),
           template_url->instant_url_ref(), kDisableStartMargin));
 }
 
 const SearchTestCase kInstantNTPTestCases[] = {
-  {"https://foo.com/instant?strk",     true,  "Valid Instant URL"},
-  {"https://foo.com/instant#strk",     true,  "Valid Instant URL"},
-  {"https://foo.com/url?strk",         true,  "Valid search URL"},
-  {"https://foo.com/url#strk",         true,  "Valid search URL"},
-  {"https://foo.com/alt?strk",         true,  "Valid alternative URL"},
-  {"https://foo.com/alt#strk",         true,  "Valid alternative URL"},
-  {"https://foo.com/url?strk&bar=",    true,  "No query terms"},
-  {"https://foo.com/url?strk&q=abc",   true,  "No query terms key"},
-  {"https://foo.com/url?strk#bar=abc", true,  "Query terms key in ref"},
-  {"https://foo.com/url?strk&bar=abc", false, "Has query terms"},
-  {"http://foo.com/instant?strk=1",    false, "Insecure URL"},
-  {"https://foo.com/instant",          false, "No search terms replacement"},
-  {"chrome://blank/",                  false, "Chrome scheme"},
-  {"chrome-search//foo",               false, "Chrome-search scheme"},
-  {chrome::kChromeSearchLocalOmniboxPopupURL, false, "Local omnibox popup"},
-  {chrome::kChromeSearchLocalNtpUrl,   true,  "Local new tab page"},
-  {"https://bar.com/instant?strk=1",   false, "Random non-search page"},
+  {"https://foo.com/instant?strk",         true,  "Valid Instant URL"},
+  {"https://foo.com/instant#strk",         true,  "Valid Instant URL"},
+  {"https://foo.com/url?strk",             true,  "Valid search URL"},
+  {"https://foo.com/url#strk",             true,  "Valid search URL"},
+  {"https://foo.com/alt?strk",             true,  "Valid alternative URL"},
+  {"https://foo.com/alt#strk",             true,  "Valid alternative URL"},
+  {"https://foo.com/url?strk&bar=",        true,  "No query terms"},
+  {"https://foo.com/url?strk&q=abc",       true,  "No query terms key"},
+  {"https://foo.com/url?strk#bar=abc",     true,  "Query terms key in ref"},
+  {"https://foo.com/url?strk&bar=abc",     false, "Has query terms"},
+  {"http://foo.com/instant?strk=1",        false, "Insecure URL"},
+  {"https://foo.com/instant",              false, "No search term replacement"},
+  {"chrome://blank/",                      false, "Chrome scheme"},
+  {"chrome-search//foo",                   false, "Chrome-search scheme"},

[sreeram, 2013/04/19 20:30:44]

Nit: Missing ":" in the scheme.

[jeremycho, 2013/04/19 20:39:36]

Done.

+  {chrome::kChromeSearchLocalNtpUrl,       true,  "Local new tab page"},
+  {chrome::kChromeSearchLocalGoogleNtpUrl, true,  "Local new tab page"},
+  {"https://bar.com/instant?strk=1",       false, "Random non-search page"},
 };
 
 TEST_F(SearchTest, InstantNTPExtendedEnabled) {
   EnableInstantExtendedAPIForTesting();
   AddTab(browser(), GURL("chrome://blank"));
   for (size_t i = 0; i < arraysize(kInstantNTPTestCases); ++i) {
     const SearchTestCase& test = kInstantNTPTestCases[i];
     NavigateAndCommitActiveTab(GURL(test.url));
+    SetSearchProvider(test.url == chrome::kChromeSearchLocalGoogleNtpUrl);
     const content::WebContents* contents =
         browser()->tab_strip_model()->GetWebContentsAt(0);
     EXPECT_EQ(test.expected_result, IsInstantNTP(contents))
         << test.url << " " << test.comment;
   }
 }
 
 TEST_F(SearchTest, InstantNTPExtendedDisabled) {
   AddTab(browser(), GURL("chrome://blank"));
   for (size_t i = 0; i < arraysize(kInstantNTPTestCases); ++i) {
     const SearchTestCase& test = kInstantNTPTestCases[i];
     NavigateAndCommitActiveTab(GURL(test.url));
     const content::WebContents* contents =
         browser()->tab_strip_model()->GetWebContentsAt(0);
     EXPECT_FALSE(IsInstantNTP(contents)) << test.url << " " << test.comment;
   }
 }
 
 TEST_F(SearchTest, InstantNTPCustomNavigationEntry) {
   EnableInstantExtendedAPIForTesting();
   AddTab(browser(), GURL("chrome://blank"));
   for (size_t i = 0; i < arraysize(kInstantNTPTestCases); ++i) {
     const SearchTestCase& test = kInstantNTPTestCases[i];
     NavigateAndCommitActiveTab(GURL(test.url));
+    SetSearchProvider(test.url == chrome::kChromeSearchLocalGoogleNtpUrl);
+
     content::WebContents* contents =
         browser()->tab_strip_model()->GetWebContentsAt(0);
     content::NavigationController& controller = contents->GetController();
     controller.SetTransientEntry(
         controller.CreateNavigationEntry(GURL("chrome://blank"),
                                          content::Referrer(),
                                          content::PAGE_TRANSITION_LINK,
                                          false,
                                          std::string(),
                                          contents->GetBrowserContext()));
@@ skipping 159 matching lines @@
     TemplateURL* template_url = new TemplateURL(profile(), data);
     // Takes ownership of |template_url|.
     template_url_service->Add(template_url);
     template_url_service->SetDefaultSearchProvider(template_url);
   }
 
   EXPECT_FALSE(DefaultSearchProviderSupportsInstant(profile()));
 }
 
 }  // namespace chrome