Issue 13905007: Remove the last remaining PLATFORM() bits from WebCore.

Issue 13905007: Remove the last remaining PLATFORM() bits from WebCore. (Closed)

Created:
7 years, 8 months ago by Nico

Modified:
7 years, 8 months ago

Reviewers:
jamesr

CC:
blink-reviews, jamesr, Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove the last remaining PLATFORM() bits from WebCore. PLATFORM(CHROMIUM) is always true, all other PLATFORMs are always false. __MAC_OS_X_VERSION_MIN_REQUIRED is always >= 1060, as 10.6 is our minimum supported OS X version. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148295

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : os_win #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : fffffffffff #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -138 lines)			Patch
M	Source/WebCore/html/HTMLSelectElement.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/page/EventHandler.cpp	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/ScrollAnimator.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/ScrollAnimator.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/Scrollbar.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/SecureTextInput.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/SecureTextInput.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/platform/graphics/Font.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/Font.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/FontCache.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/platform/graphics/FontCache.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/FontDescription.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/FontPlatformData.h	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/WebCore/platform/graphics/FontPlatformData.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/GlyphBuffer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/SimpleFontData.h	View		5 chunks	+7 lines, -18 lines	0 comments	Download
M	Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm	View		8 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm	View		2 chunks	+1 line, -10 lines	0 comments	Download
M	Source/WebCore/platform/graphics/mac/FontCacheMac.mm	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp	View		2 chunks	+0 lines, -37 lines	0 comments	Download
M	Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/WebCore/platform/mac/WebCoreNSCellExtras.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/WebCore/platform/mac/WebCoreSystemInterface.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/mac/WebCoreSystemInterface.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/platform/mac/WebFontCache.mm	View	1 2 3 4 5	4 chunks	+0 lines, -16 lines	0 comments	Download
M	Source/WebCore/platform/text/cf/HyphenationCF.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/13905007/diff/2001/Source/WebCore/page/EventHandler.cpp File Source/WebCore/page/EventHandler.cpp (right): https://codereview.chromium.org/13905007/diff/2001/Source/WebCore/page/EventHandler.cpp#newcode2198 Source/WebCore/page/EventHandler.cpp:2198: #if !(OS(UNIX) && !OS(DARWIN)) !(OS(UNIX) && !OS(DARWIN)) !OS(UNIX) ...

7 years, 8 months ago (2013-04-12 02:38:53 UTC) #2

Nico

Thanks! https://codereview.chromium.org/13905007/diff/2001/Source/WebCore/page/EventHandler.cpp File Source/WebCore/page/EventHandler.cpp (right): https://codereview.chromium.org/13905007/diff/2001/Source/WebCore/page/EventHandler.cpp#newcode2198 Source/WebCore/page/EventHandler.cpp:2198: #if !(OS(UNIX) && !OS(DARWIN)) On 2013/04/12 02:38:53, jamesr ...

7 years, 8 months ago (2013-04-12 04:04:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/13905007/8028

7 years, 8 months ago (2013-04-12 04:07:35 UTC) #4

commit-bot: I haz the power

Presubmit check for 13905007-8028 failed and returned exit status 1. INFO:root:Found 27 file(s). Running presubmit ...

7 years, 8 months ago (2013-04-12 04:08:03 UTC) #5

Nico

7 years, 8 months ago (2013-04-12 17:28:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #6 manually as r148295 (presubmit successful).

Expand Messages | Collapse Messages