Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1390483002: [Interpreter] Unary operators - typeof, void, and logical not. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index c41dee3df9beae2c73dda7ea0252e570974e97ea..4d0483a4cf3090f31e37f822ddfb39a29e9433bb 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -1260,6 +1260,123 @@ TEST(BasicLoops) {
}
}
+
+TEST(UnaryOperators) {
+ InitializedHandleScope handle_scope;
+ BytecodeGeneratorHelper helper;
+
+ ExpectedSnippet<int> snippets[] = {
+ {"var x = 0;"
+ "while (x != 10) {"
+ " x = x + 10;"
+ "}"
+ "return x;",
+ 2 * kPointerSize,
+ 1,
+ 29,
+ {
+ B(LdaZero), // 0
+ B(Star), R(0), // 1
+ B(Jump), U8(12), // 3
+ B(Ldar), R(0), // 5
+ B(Star), R(1), // 7
+ B(LdaSmi8), U8(10), // 9
+ B(Add), R(1), // 11
+ B(Star), R(0), // 13
+ B(Ldar), R(0), // 15
+ B(Star), R(1), // 17
+ B(LdaSmi8), U8(10), // 19
+ B(TestEqual), R(1), // 21
+ B(LogicalNot), // 23
+ B(JumpIfTrue), U8(-19), // 24
+ B(Ldar), R(0), // 26
+ B(Return), // 28
+ },
+ 0},
+ {"var x = false;"
+ "do {"
+ " x = !x;"
+ "} while(x == false);"
+ "return x;",
+ 2 * kPointerSize,
+ 1,
+ 20,
+ {
+ B(LdaFalse), // 0
+ B(Star), R(0), // 1
+ B(Ldar), R(0), // 3
+ B(LogicalNot), // 5
+ B(Star), R(0), // 6
+ B(Ldar), R(0), // 8
+ B(Star), R(1), // 10
+ B(LdaFalse), // 12
+ B(TestEqual), R(1), // 13
+ B(JumpIfTrue), U8(-12), // 15
+ B(Ldar), R(0), // 17
+ B(Return), // 19
rmcilroy 2015/10/06 10:39:15 nit - be consistent (either bytecode numbers for a
oth 2015/10/06 12:35:06 Done.
oth 2015/10/06 13:52:09 Done.
+ },
+ 0},
+ {"var x = 101;"
+ "return void(x * 3);",
+ 2 * kPointerSize,
+ 1,
+ 14,
+ {
+ B(LdaSmi8), U8(101), //
+ B(Star), R(0), //
+ B(Ldar), R(0), //
+ B(Star), R(1), //
+ B(LdaSmi8), U8(3), //
+ B(Mul), R(1), //
+ B(LdaUndefined), //
+ B(Return), //
+ },
+ 0},
+ {"var x = 1234;"
+ "var y = void (x * x - 1);"
+ "return y;",
+ 4 * kPointerSize,
+ 1,
+ 24,
+ {
+ B(LdaConstant), U8(0), // 0
+ B(Star), R(0), // 2
+ B(Ldar), R(0), // 4
+ B(Star), R(3), // 6
+ B(Ldar), R(0), // 8
+ B(Mul), R(3), // 10
+ B(Star), R(2), // 12
+ B(LdaSmi8), U8(1), // 14
+ B(Sub), R(2), // 16
+ B(LdaUndefined), // 18
+ B(Star), R(1), // 19
+ B(Ldar), R(1), // 21
+ B(Return), // 23
+ },
+ 1, {1234}},
+ {"var x = 13;"
+ "return typeof(x);",
+ 1 * kPointerSize,
+ 1,
+ 8,
+ {
+ B(LdaSmi8), U8(13), //
+ B(Star), R(0), //
+ B(Ldar), R(0), //
+ B(TypeOf), //
+ B(Return), //
+ },
+ 0},
+ };
+
+ for (size_t i = 0; i < arraysize(snippets); i++) {
+ Handle<BytecodeArray> bytecode_array =
+ helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
+ CheckBytecodeArrayEqual(snippets[i], bytecode_array);
+ }
+}
+
+
} // namespace interpreter
} // namespace internal
} // namespace v8

Powered by Google App Engine
This is Rietveld 408576698