Reland [swarming] Isolate v8 testing.

Reland [swarming] Isolate v8 testing.

This reverts commit 280a6f8ec84327692a4dedf4edc1ea72f5d5ba73.

Reland of https://codereview.chromium.org/1380593002/

BUG=chromium:535160
LOG=n
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel;

Committed: https://crrev.com/e1743816d303cc148850593cccb53ae039134509
Cr-Commit-Position: refs/heads/master@{#31094}

[Michael Achenbach, 2015-10-05 08:41:29]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-05 08:41:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390473003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390473003/20001

[commit-bot: I haz the power, 2015-10-05 08:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 08:42:52]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/10303)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/8652)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/9258)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/10218)

[Michael Achenbach, 2015-10-05 08:43:07]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2015-10-05 08:43:08]

PTAL

https://codereview.chromium.org/1390473003/diff/20001/src/base.isolate
File src/base.isolate (right):

https://codereview.chromium.org/1390473003/diff/20001/src/base.isolate#newcode6
src/base.isolate:6: ['v8_use_snapshot=="true" and
v8_use_external_startup_data==1', {
See
https://code.google.com/p/chromium/codesearch#chromium/src/v8/build/features....

[Michael Achenbach, 2015-10-05 08:43:31]

Ah - don't take a look yet...

[Michael Achenbach, 2015-10-05 09:10:46]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-05 09:10:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390473003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390473003/40001

[jochen (gone - plz use gerrit), 2015-10-05 09:17:51]

lgtm

[Michael Achenbach, 2015-10-05 09:24:03]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2015-10-05 09:24:06]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-10-05 09:24:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390473003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390473003/40001

[commit-bot: I haz the power, 2015-10-05 09:48:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-05 09:48:53]

Patchset 3 (id:??) landed as
https://crrev.com/e1743816d303cc148850593cccb53ae039134509
Cr-Commit-Position: refs/heads/master@{#31094}

[Dan Ehrenberg, 2015-10-05 23:17:28]

On 2015/10/05 at 09:48:53, commit-bot wrote:
> Patchset 3 (id:??) landed as
https://crrev.com/e1743816d303cc148850593cccb53ae039134509
> Cr-Commit-Position: refs/heads/master@{#31094}

This seems to break the build for me. With this patch, make gives me errors like
this:

dehrenberg@dehrenberg:~/v8/v8$ gm x64.debug
PYTHONPATH="/usr/local/google/home/dehrenberg/v8/v8/tools/generate_shim_headers:/usr/local/google/home/dehrenberg/v8/v8/build:/usr/local/buildtools/current/sitecustomize:/usr/local/google/home/dehrenberg/v8/v8/build/gyp/pylib:/usr/local/buildtools/current/sitecustomize"
\
        GYP_GENERATORS=make \
        build/gyp/gyp --generator-output="out" build/all.gyp \
                      -Ibuild/standalone.gypi --depth=. \
                      -Dv8_target_arch=x64 \
                       -Dtarget_arch=x64 \
                       \
                      -S.x64.debug -Duse_goma=1 -Dv8_enable_disassembler=1
-Dv8_object_print=1 -Dv8_enable_backtrace=1 -Darm_fpu=default
-Darm_float_abi=default
make[1]: Entering directory `/usr/local/google/home/dehrenberg/v8/v8/out'
make[1]: *** No rule to make target `../tools/swarming_client/isolate.py',
needed by
`/usr/local/google/home/dehrenberg/v8/v8/out/x64.debug/cctest.isolated'.  Stop.
make[1]: Leaving directory `/usr/local/google/home/dehrenberg/v8/v8/out'
make: *** [x64.debug] Error 2

What went into determining that this patch was ready to reland? Reverting the
patch seems to fix my build issues.

[Michael Achenbach, 2015-10-06 06:50:53]

machenbach@chromium.org changed reviewers:
+ littledan@chromium.org

[Michael Achenbach, 2015-10-06 06:50:54]

On 2015/10/05 23:17:28, Dan Ehrenberg wrote:
> On 2015/10/05 at 09:48:53, commit-bot wrote:
> > Patchset 3 (id:??) landed as
> https://crrev.com/e1743816d303cc148850593cccb53ae039134509
> > Cr-Commit-Position: refs/heads/master@{#31094}
> 
> This seems to break the build for me. With this patch, make gives me errors
like
> this:
> 
> dehrenberg@dehrenberg:~/v8/v8$ gm x64.debug
>
PYTHONPATH="/usr/local/google/home/dehrenberg/v8/v8/tools/generate_shim_headers:/usr/local/google/home/dehrenberg/v8/v8/build:/usr/local/buildtools/current/sitecustomize:/usr/local/google/home/dehrenberg/v8/v8/build/gyp/pylib:/usr/local/buildtools/current/sitecustomize"
> \
>         GYP_GENERATORS=make \
>         build/gyp/gyp --generator-output="out" build/all.gyp \
>                       -Ibuild/standalone.gypi --depth=. \
>                       -Dv8_target_arch=x64 \
>                        -Dtarget_arch=x64 \
>                        \
>                       -S.x64.debug -Duse_goma=1 -Dv8_enable_disassembler=1
> -Dv8_object_print=1 -Dv8_enable_backtrace=1 -Darm_fpu=default
> -Darm_float_abi=default
> make[1]: Entering directory `/usr/local/google/home/dehrenberg/v8/v8/out'
> make[1]: *** No rule to make target `../tools/swarming_client/isolate.py',
> needed by
> `/usr/local/google/home/dehrenberg/v8/v8/out/x64.debug/cctest.isolated'. 
Stop.
> make[1]: Leaving directory `/usr/local/google/home/dehrenberg/v8/v8/out'
> make: *** [x64.debug] Error 2
> 
> What went into determining that this patch was ready to reland? Reverting the
> patch seems to fix my build issues.

Can it be that you didn't 'gclient sync'? Please try that as I can't reproduce.

We have coverage for 'make' in the CQ and the CL passed. It looks like make just
cant find the isolate script, which comes as a dependency.