Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: runtime/vm/heap.cc

Issue 139043003: - Address warnings about 64-bit to 32-bit conversions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/heap.h ('k') | runtime/vm/heap_profiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap.cc
===================================================================
--- runtime/vm/heap.cc (revision 31864)
+++ runtime/vm/heap.cc (working copy)
@@ -8,7 +8,6 @@
#include "platform/utils.h"
#include "vm/flags.h"
#include "vm/heap_histogram.h"
-#include "vm/heap_profiler.h"
#include "vm/isolate.h"
#include "vm/object.h"
#include "vm/object_set.h"
@@ -321,45 +320,6 @@
}
-void Heap::Profile(Dart_FileWriteCallback callback, void* stream) const {
- HeapProfiler profiler(callback, stream);
-
- // Dump the root set.
- HeapProfilerRootVisitor root_visitor(&profiler);
- Isolate* isolate = Isolate::Current();
- Isolate* vm_isolate = Dart::vm_isolate();
- isolate->VisitObjectPointers(&root_visitor, false,
- StackFrameIterator::kDontValidateFrames);
- HeapProfilerWeakRootVisitor weak_root_visitor(&root_visitor);
- isolate->VisitWeakPersistentHandles(&weak_root_visitor, true);
-
- // Dump the current and VM isolate heaps.
- HeapProfilerObjectVisitor object_visitor(isolate, &profiler);
- isolate->heap()->IterateObjects(&object_visitor);
- vm_isolate->heap()->IterateObjects(&object_visitor);
-}
-
-
-void Heap::ProfileToFile(const char* reason) const {
- Dart_FileOpenCallback file_open = Isolate::file_open_callback();
- ASSERT(file_open != NULL);
- Dart_FileWriteCallback file_write = Isolate::file_write_callback();
- ASSERT(file_write != NULL);
- Dart_FileCloseCallback file_close = Isolate::file_close_callback();
- ASSERT(file_close != NULL);
- Isolate* isolate = Isolate::Current();
- const char* format = "%s-%s.hprof";
- intptr_t len = OS::SNPrint(NULL, 0, format, isolate->name(), reason);
- char* filename = isolate->current_zone()->Alloc<char>(len + 1);
- OS::SNPrint(filename, len + 1, format, isolate->name(), reason);
- void* file = (*file_open)(filename, true);
- if (file != NULL) {
- Profile(file_write, file);
- (*file_close)(file);
- }
-}
-
-
const char* Heap::GCReasonToString(GCReason gc_reason) {
switch (gc_reason) {
case kNewSpace:
« no previous file with comments | « runtime/vm/heap.h ('k') | runtime/vm/heap_profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698