Issue 13904002: Remove C++11 usage from Clang tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13904002: Remove C++11 usage from Clang tools. (Closed)

Created:
7 years, 8 months ago by dcheng

Modified:
7 years, 8 months ago

Reviewers:
Nico

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Remove C++11 usage from Clang tools. I guess I shouldn't have ignored the compiler warnings. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193023

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	tools/clang/empty_string/EmptyStringConverter.cpp	View		2 chunks	+5 lines, -4 lines	0 comments	Download
	M	tools/clang/rewrite_scoped_array/RewriteScopedArray.cpp	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

dcheng

This doesn't build if your CC/CXX is gcc. Oops. Down with C++11?

7 years, 8 months ago (2013-04-09 03:40:43 UTC) #1

dcheng

7 years, 8 months ago (2013-04-09 05:46:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r193023 (presubmit successful).