Adds MUSViewsInit

Adds MUSViewsInit

MUSViewsInit is a ViewsDelegate that intercepts CreateNativeWidget to
create NWVM.
Changes ViewTreeConnection to have the option to block until OnEmbed.
Updates examples.

I hacked WindowTypeLauncher to get this to work. See comment there for
specifics. Will sort out after this.

BUG=none
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/a66540c5231cfec8098fe6642ba437da95a5919f
Cr-Commit-Position: refs/heads/master@{#354040}

[sky, 2015-10-14 02:31:29]

Also note that there are initial sizing problems with this patch. Will
sort that out later too.

On Tue, Oct 13, 2015 at 7:30 PM,  <sky@chromium.org> wrote:
> Reviewers: Ben Goodger (Google),
>
> Description:
> Adds MUSViewsInit
>
> MUSViewsInit is a ViewsDelegate that intercepts CreateNativeWidget to
> create NWVM.
> Changes ViewTreeConnection to have the option to block until OnEmbed.
> Updates examples.
>
> I hacked WindowTypeLauncher to get this to work. See comment there for
> specifics. Will sort out after this.
>
> BUG=none
> TEST=none
> R=ben@chromium.org
>
> Please review this at https://codereview.chromium.org/1390353007/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+195, -166 lines):
>   M components/html_viewer/html_document.cc
>   M components/mus/example/client/BUILD.gn
>   M components/mus/example/client/client_application_delegate.h
>   M components/mus/example/client/client_application_delegate.cc
>   A + components/mus/example/common/BUILD.gn
>   A + components/mus/example/common/DEPS
>   A components/mus/example/common/mus_views_init.h
>   A components/mus/example/common/mus_views_init.cc
>   M components/mus/example/window_type_launcher/BUILD.gn
>   M components/mus/example/window_type_launcher/window_type_launcher.h
>   M components/mus/example/window_type_launcher/window_type_launcher.cc
>   M components/mus/public/cpp/lib/view_tree_client_impl.h
>   M components/mus/public/cpp/lib/view_tree_client_impl.cc
>   M components/mus/public/cpp/lib/view_tree_host_factory.cc
>   M components/mus/public/cpp/tests/view_manager_test_base.cc
>   M components/mus/public/cpp/view_tree_connection.h
>   M components/pdf_viewer/pdf_viewer.cc
>   M components/web_view/frame_apptest.cc
>   M components/web_view/web_view_impl.cc
>   M mandoline/ui/omnibox/omnibox_application.cc
>   M ui/views/views_delegate.h
>   M ui/views/views_delegate.cc
>   M ui/views/widget/widget.cc
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2015-10-14 03:03:58]

lgtm

https://codereview.chromium.org/1390353007/diff/20001/components/mus/example/...
File components/mus/example/window_type_launcher/window_type_launcher.cc
(right):

https://codereview.chromium.org/1390353007/diff/20001/components/mus/example/...
components/mus/example/window_type_launcher/window_type_launcher.cc:364: // here
we ensure the necessary state has been setup.
seems like we need to find aurainit some other way of getting viewport metrics.

[sky, 2015-10-14 15:32:35]

https://codereview.chromium.org/1390353007/diff/20001/components/mus/example/...
File components/mus/example/window_type_launcher/window_type_launcher.cc
(right):

https://codereview.chromium.org/1390353007/diff/20001/components/mus/example/...
components/mus/example/window_type_launcher/window_type_launcher.cc:364: // here
we ensure the necessary state has been setup.
On 2015/10/14 03:03:58, Ben Goodger (Google) wrote:
> seems like we need to find aurainit some other way of getting viewport
metrics.

Agreed. It would be nice if we could provide it as part of Initialize, but
viewport metrics are hardly applicable to all apps.

WDYT of an API on the VM that you can connect to and get screen information?
That's really what we need here.

[sky, 2015-10-14 15:35:00]

The CQ bit was checked by sky@chromium.org

[sky, 2015-10-14 15:35:00]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1390353007/#ps40001
(title: "allow for null delegate")

[commit-bot: I haz the power, 2015-10-14 15:35:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390353007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390353007/40001

[sky, 2015-10-14 16:01:53]

The CQ bit was checked by sky@chromium.org

[sky, 2015-10-14 16:01:53]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1390353007/#ps60001
(title: "fix windows")

[commit-bot: I haz the power, 2015-10-14 16:02:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1390353007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1390353007/60001

[commit-bot: I haz the power, 2015-10-14 16:41:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-14 16:42:18]

Patchset 4 (id:??) landed as
https://crrev.com/a66540c5231cfec8098fe6642ba437da95a5919f
Cr-Commit-Position: refs/heads/master@{#354040}