Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1390343004: PPC: Vector ICs: Get rid of stack arguments on ia32 transitioning stores. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Vector ICs: Get rid of stack arguments on ia32 transitioning stores. Port 2d4aeaad2fa3888c5e4cbfd30f6338e1fbf794e9 Original commit message: The stack manipulation was expensive. Two virtual registers are better. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/f7a35b9a6ea04e4c9331a75c24846d38d4a210c2 Cr-Commit-Position: refs/heads/master@{#31213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
MTBrandyberry
5 years, 2 months ago (2015-10-12 13:49:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390343004/1
5 years, 2 months ago (2015-10-12 13:49:19 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-12 14:11:15 UTC) #5
dstence
lgtm
5 years, 2 months ago (2015-10-12 14:26:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390343004/1
5 years, 2 months ago (2015-10-12 14:31:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390343004/1
5 years, 2 months ago (2015-10-12 15:07:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 15:18:22 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 15:18:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7a35b9a6ea04e4c9331a75c24846d38d4a210c2
Cr-Commit-Position: refs/heads/master@{#31213}

Powered by Google App Engine
This is Rietveld 408576698