build/common.gypi - Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index cce7b3ca56ed001a1e3f08c54cc1e076e68aee53..5ff6c7b5058cb4efe57ce85c8540452ef533a717 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -5763,7 +5763,10 @@

'-Qunused-arguments', # http://crbug.com/504658

'-Wno-microsoft-enum-value', # http://crbug.com/505296

'-Wno-unknown-pragmas', # http://crbug.com/505314

- '-Wno-unused-value', # http://crbug.com/505318

+ # Disable unused-value (crbug.com/505318) except

+ # -Wunused-result.

+ '-Wno-unused-value',

+ '-Wunused-result',

}],

« no previous file with comments | « base/compiler_specific.h ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »