Enforce WARN_UNUSED_RESULT attribute on Windows

net/dns/address_sorter_win.cc

Index: net/dns/address_sorter_win.cc
diff --git a/net/dns/address_sorter_win.cc b/net/dns/address_sorter_win.cc
index 8d97a41111be95bcecb39cbb5efa4f9e703ce99d..f469dae5f1e0e0e233f7db86bace38a76d187de7 100644
--- a/net/dns/address_sorter_win.cc
+++ b/net/dns/address_sorter_win.cc
@@ -109,8 +109,11 @@ class AddressSorterWin : public AddressSorter {
         list.reserve(output_buffer_->iAddressCount);
         for (int i = 0; i < output_buffer_->iAddressCount; ++i) {
           IPEndPoint ipe;
-          ipe.FromSockAddr(output_buffer_->Address[i].lpSockaddr,
-                           output_buffer_->Address[i].iSockaddrLength);
+          bool result =
+              ipe.FromSockAddr(output_buffer_->Address[i].lpSockaddr,
+                               output_buffer_->Address[i].iSockaddrLength);
+          DCHECK(result) << "Unable to roundtrip between IPEndPoint and "

[Deprecated (see juliatuttle), 2015/10/07 18:25:41]

Perhaps also continue; the loop if result is false, since ipe will be empty
anyway?

[dcheng, 2015/10/07 18:52:01]

Basically, as I see it, if this ever fails, something already went really wrong:
either way, the result is broken. There are either empty IPEndpoints, or the
sorted list is somehow shorter.

Thus, I think the right thing to do is just DCHECK, since this "should never
happen".

+                         << "SOCKET_ADDRESS!";
           // Unmap V4MAPPED IPv6 addresses so that Happy Eyeballs works.
           if (IsIPv4Mapped(ipe.address())) {
             ipe = IPEndPoint(ConvertIPv4MappedToIPv4(ipe.address()),