Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/toolchain/ccache.gni") 8 import("//build/toolchain/ccache.gni")
9 9
10 if (current_cpu == "arm") { 10 if (current_cpu == "arm") {
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 568
569 # Building with Clang on Windows is a work in progress and very 569 # Building with Clang on Windows is a work in progress and very
570 # experimental. See crbug.com/82385. 570 # experimental. See crbug.com/82385.
571 # Keep this in sync with the similar block in build/common.gypi 571 # Keep this in sync with the similar block in build/common.gypi
572 if (is_clang) { 572 if (is_clang) {
573 cflags += [ 573 cflags += [
574 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657 574 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657
575 "-Qunused-arguments", # http://crbug.com/504658 575 "-Qunused-arguments", # http://crbug.com/504658
576 "-Wno-microsoft-enum-value", # http://crbug.com/505296 576 "-Wno-microsoft-enum-value", # http://crbug.com/505296
577 "-Wno-unknown-pragmas", # http://crbug.com/505314 577 "-Wno-unknown-pragmas", # http://crbug.com/505314
578 "-Wno-unused-value", # http://crbug.com/505318 578
579 # Disable unused-value (crbug.com/505318) except -Wunused-result.
580 "-Wno-unused-value",
581 "-Wunused-result",
579 ] 582 ]
580 } 583 }
581 } else { 584 } else {
582 # Common GCC warning setup. 585 # Common GCC warning setup.
583 cflags += [ 586 cflags += [
584 # Enables. 587 # Enables.
585 "-Wendif-labels", # Weird old-style text after an #endif. 588 "-Wendif-labels", # Weird old-style text after an #endif.
586 "-Werror", # Warnings as errors. 589 "-Werror", # Warnings as errors.
587 590
588 # Disables. 591 # Disables.
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
1113 if (symbol_level == 0) { 1116 if (symbol_level == 0) {
1114 configs = [ ":no_symbols" ] 1117 configs = [ ":no_symbols" ]
1115 } else if (symbol_level == 1) { 1118 } else if (symbol_level == 1) {
1116 configs = [ ":minimal_symbols" ] 1119 configs = [ ":minimal_symbols" ]
1117 } else if (symbol_level == 2) { 1120 } else if (symbol_level == 2) {
1118 configs = [ ":symbols" ] 1121 configs = [ ":symbols" ]
1119 } else { 1122 } else {
1120 assert(false) 1123 assert(false)
1121 } 1124 }
1122 } 1125 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698