src/codec/SkWebpCodec.cpp - Issue 1390213002: Add subsetting to SkScanlineDecoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkWebpCodec.cpp

Issue 1390213002: Add subsetting to SkScanlineDecoder (Closed) Base URL: https://skia.googlesource.com/skia.git@fill-refactor

Patch Set: Response to comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkWebpCodec.cpp

diff --git a/src/codec/SkWebpCodec.cpp b/src/codec/SkWebpCodec.cpp

index a0fab0a153d67f0d32375ac7405d06314a7bb317..3c61b937622097d5e1c5be483770a6fb2336543a 100644

--- a/src/codec/SkWebpCodec.cpp

+++ b/src/codec/SkWebpCodec.cpp

@@ -144,8 +144,8 @@ bool SkWebpCodec::onGetValidSubset(SkIRect* desiredSubset) const {

return false;

}

- SkIRect bounds = SkIRect::MakeSize(this->getInfo().dimensions());

- if (!desiredSubset->intersect(bounds)) {

+ SkIRect dimensions = SkIRect::MakeSize(this->getInfo().dimensions());

+ if (!dimensions.contains(*desiredSubset)) {

return false;

}

« no previous file with comments | « src/codec/SkSwizzler.cpp ('k') | no next file » | no next file with comments »