src/codec/SkBmpCodec.cpp - Issue 1390213002: Add subsetting to SkScanlineDecoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkBmpCodec.cpp

Issue 1390213002: Add subsetting to SkScanlineDecoder (Closed) Base URL: https://skia.googlesource.com/skia.git@fill-refactor

Patch Set: Clean up and response to comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkBmpCodec.cpp

diff --git a/src/codec/SkBmpCodec.cpp b/src/codec/SkBmpCodec.cpp

index 1aa43f583cbcc2a536c6f1b8e8fb6dd15acb7be5..0222c8ce9fbb2ec2ef809063089bb00beedcaa17 100644

--- a/src/codec/SkBmpCodec.cpp

+++ b/src/codec/SkBmpCodec.cpp

@@ -564,10 +564,6 @@ uint32_t SkBmpCodec::computeNumColors(uint32_t numColors) {

SkCodec::Result SkBmpCodec::onStartScanlineDecode(const SkImageInfo& dstInfo,

const SkCodec::Options& options, SkPMColor inputColorPtr[], int* inputColorCount) {

- if (options.fSubset) {

- // Subsets are not supported.

- return kUnimplemented;

- }

if (!conversion_possible(dstInfo, this->getInfo())) {

SkCodecPrintf("Error: cannot convert input type to output type.\n");

return kInvalidConversion;