Add subsetting to SkScanlineDecoder

include/codec/SkCodec.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkCodec_DEFINED
 #define SkCodec_DEFINED
 
@@ skipping 155 matching lines @@
         {}
 
         ZeroInitialized fZeroInitialized;
         /**
          *  If not NULL, represents a subset of the original image to decode.
          *
          *  Must be within the bounds returned by getInfo().
          *
          *  If the EncodedFormat is kWEBP_SkEncodedFormat (the only one which
          *  currently supports subsets), the top and left values must be even.
+         *
+         *  The above description applies to getPixels() but the usage is

[scroggo, 2015/10/12 16:11:20]

I think it would be better to say something like:

In getPixels, ... (explanation for how it's used in getPixels)

In scanline decoding,  ..

[msarett, 2015/10/12 17:13:55]

Done.

+         *  slightly different when we want to startScanlineDecode().  It
+         *  does not make a lot of sense to specify a fSubsetTop or
+         *  fSubsetHeight when scanline decoding, since the client already
+         *  controls which rows to get and which rows to skip.  During scanline
+         *  decodes, we will require that fSubsetTop be zero and fSubsetHeight
+         *  be the full height.  We will, however, use the values of
+         *  fSubsetLeft and fSubsetWidth to decode partial scanlines on calls
+         *  to getScanlines().
          */
         SkIRect*        fSubset;
     };
 
     /**
      *  Decode into the given pixels, a block of memory of size at
      *  least (info.fHeight - 1) * rowBytes + (info.fWidth *
      *  bytesPerPixel)
      *
      *  Repeated calls to this function should give the same results,
@@ skipping 66 matching lines @@
      *  @param ctable A pointer to a color table.  When dstInfo.colorType() is
      *      kIndex8, this should be non-NULL and have enough storage for 256
      *      colors.  The color table will be populated after decoding the palette.
      *  @param ctableCount A pointer to the size of the color table.  When
      *      dstInfo.colorType() is kIndex8, this should be non-NULL.  It will
      *      be modified to the true size of the color table (<= 256) after
      *      decoding the palette.
      *  @return Enum representing success or reason for failure.
      */
     Result startScanlineDecode(const SkImageInfo& dstInfo, const SkCodec::Options* options,
-                 SkPMColor ctable[], int* ctableCount);
+            SkPMColor ctable[], int* ctableCount);
 
     /**
      *  Simplified version of startScanlineDecode() that asserts that info is NOT
-     *  kIndex8_SkColorType and uses the default Options.
+     *  kIndex8_SkColorType and uses the default options.

[scroggo, 2015/10/12 16:11:20]

Why this change?

[msarett, 2015/10/12 17:13:55]

I changed this comment when I changed the API, and then I unchanged it, but it
looks like I didn't unchange it properly.

Will fix.

      */
     Result startScanlineDecode(const SkImageInfo& dstInfo);
 
     /**
      *  Write the next countLines scanlines into dst.
      *
      *  Not valid to call before calling startScanlineDecode().
      *
      *  @param dst Must be non-null, and large enough to hold countLines
      *      scanlines of size rowBytes.
@@ skipping 294 matching lines @@
      *  May create a sampler, if one is not currently being used. Otherwise, does
      *  not affect ownership.
      *
      *  Only valid during scanline decoding.
      */
     virtual SkSampler* getSampler(bool createIfNecessary) { return nullptr; }
 
     friend class SkScaledCodec;
 };
 #endif // SkCodec_DEFINED