Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13902013: Improve handling of unary plus. (Closed)

Created:
7 years, 8 months ago by Sven Panne
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Improve handling of unary plus. Simple strategy: Transform unary plus into multiplication by one directly in the parser and remove it from the Hydrogen graph later. This gives correct type feedback without any special stub for it. BUG=v8:2527 Committed: http://code.google.com/p/v8/source/detail?r=14306

Patch Set 1 #

Patch Set 2 : Simplified #

Patch Set 3 : More simplifications #

Patch Set 4 : Removed unary plus node handling #

Total comments: 1

Patch Set 5 : Whitespace #

Patch Set 6 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -66 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M src/hydrogen.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 2 chunks +0 lines, -16 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
M src/parser.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
Looks almost too easy. Is there a hidden problem with this approach?
7 years, 8 months ago (2013-04-16 14:04:37 UTC) #1
Sven Panne
Simplified & cleaned up. Removed superfluous code. PTAL...
7 years, 8 months ago (2013-04-17 10:57:39 UTC) #2
Jakob Kummerow
LGTM with a nit. https://codereview.chromium.org/13902013/diff/7002/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/13902013/diff/7002/src/hydrogen-instructions.cc#newcode1445 src/hydrogen-instructions.cc:1445: nit: two newlines between top-level ...
7 years, 8 months ago (2013-04-17 12:36:07 UTC) #3
Sven Panne
7 years, 8 months ago (2013-04-17 12:47:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #6 manually as r14306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698