Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1390193003: [win32] Make sure OS::Abort doesn't return (Closed)

Created:
5 years, 2 months ago by skomski
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[win32] Make sure OS::Abort doesn't return Fixes clang on windows warning: ..\..\v8\src\base\platform\platform-win32.cc(836,1) : error: function declared 'noreturn' should not return [-Werror,-Winvalid-noreturn] CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_rel,win_clang_x64_rel Committed: https://crrev.com/2daea448d9089018e9d52618958fda63e815237a Cr-Commit-Position: refs/heads/master@{#31194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/base/platform/platform-win32.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
skomski
PTAL
5 years, 2 months ago (2015-10-09 06:45:33 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-10-09 09:40:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390193003/1
5 years, 2 months ago (2015-10-09 09:44:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 12:52:23 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2daea448d9089018e9d52618958fda63e815237a Cr-Commit-Position: refs/heads/master@{#31194}
5 years, 2 months ago (2015-10-09 12:52:42 UTC) #10
hans
machenbach: Can you help get this rolled into Chromium? Our Windows Clang builds are broken ...
5 years, 2 months ago (2015-10-09 16:57:19 UTC) #12
Reid Kleckner
5 years, 2 months ago (2015-10-09 18:34:17 UTC) #14
Message was sent while issue was closed.
The V8 autoroller got it in:
https://chromium.googlesource.com/chromium/src/+/d8ecceb196bcc4a845d51a05bb5e...

Powered by Google App Engine
This is Rietveld 408576698