Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 139013008: Implement support for rendering to 32-bit float textures on ES3 (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address review feedback, split extension and add tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.h
diff --git a/gpu/command_buffer/service/framebuffer_manager.h b/gpu/command_buffer/service/framebuffer_manager.h
index c469bf8743503a90eccdb57dad657f6477667414..73070873dff230865a469b3d229fe097debb6db5 100644
--- a/gpu/command_buffer/service/framebuffer_manager.h
+++ b/gpu/command_buffer/service/framebuffer_manager.h
@@ -46,7 +46,9 @@ class GPU_EXPORT Framebuffer : public base::RefCounted<Framebuffer> {
virtual bool CanRenderTo() const = 0;
virtual void DetachFromFramebuffer(Framebuffer* framebuffer) const = 0;
virtual bool ValidForAttachmentType(
- GLenum attachment_type, uint32 max_color_attachments) = 0;
+ GLenum attachment_type, uint32 max_color_attachments,
+ bool allow_float_rgba_color_attachment,
+ bool allow_float_rgb_color_attachment) = 0;
virtual void AddToSignature(
TextureManager* texture_manager, std::string* signature) const = 0;
@@ -115,7 +117,8 @@ class GPU_EXPORT Framebuffer : public base::RefCounted<Framebuffer> {
// Note that receiving GL_FRAMEBUFFER_COMPLETE from this function does
// not mean the real OpenGL will consider it framebuffer complete. It just
// means it passed our tests.
- GLenum IsPossiblyComplete() const;
+ GLenum IsPossiblyComplete(bool allow_float_rgba_color_attachment,
+ bool allow_float_rgb_color_attachment) const;
piman 2014/02/07 19:03:25 nit: Would it make sense to pass the FeatureInfo h
// Implements optimized glGetFramebufferStatus.
GLenum GetStatus(TextureManager* texture_manager, GLenum target) const;
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698