Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: gpu/command_buffer/service/texture_manager_unittest.cc

Issue 139013008: Implement support for rendering to 32-bit float textures on ES3 (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Check that framebuffers really are supported and add tests Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/texture_manager_unittest.cc
diff --git a/gpu/command_buffer/service/texture_manager_unittest.cc b/gpu/command_buffer/service/texture_manager_unittest.cc
index 002f2f85573288ba011a54d7b04cae598e26d92c..38c2746ccd35e850dae29939c757c8c58f1d1bab 100644
--- a/gpu/command_buffer/service/texture_manager_unittest.cc
+++ b/gpu/command_buffer/service/texture_manager_unittest.cc
@@ -2272,7 +2272,7 @@ TEST_F(SharedTextureTest, FBOCompletenessCheck) {
framebuffer1->AttachTexture(
GL_COLOR_ATTACHMENT0, ref1.get(), GL_TEXTURE_2D, 0, 0);
EXPECT_FALSE(framebuffer_manager1.IsComplete(framebuffer1.get()));
- EXPECT_NE(kCompleteValue, framebuffer1->IsPossiblyComplete());
+ EXPECT_NE(kCompleteValue, framebuffer1->IsPossiblyComplete(false));
// Make FBO complete in manager 1.
texture_manager1_->SetTarget(ref1.get(), GL_TEXTURE_2D);
@@ -2287,7 +2287,7 @@ TEST_F(SharedTextureTest, FBOCompletenessCheck) {
GL_RGBA,
GL_UNSIGNED_BYTE,
true);
- EXPECT_EQ(kCompleteValue, framebuffer1->IsPossiblyComplete());
+ EXPECT_EQ(kCompleteValue, framebuffer1->IsPossiblyComplete(false));
framebuffer_manager1.MarkAsComplete(framebuffer1.get());
EXPECT_TRUE(framebuffer_manager1.IsComplete(framebuffer1.get()));
@@ -2300,7 +2300,7 @@ TEST_F(SharedTextureTest, FBOCompletenessCheck) {
framebuffer2->AttachTexture(
GL_COLOR_ATTACHMENT0, ref2.get(), GL_TEXTURE_2D, 0, 0);
EXPECT_FALSE(framebuffer_manager2.IsComplete(framebuffer2.get()));
- EXPECT_EQ(kCompleteValue, framebuffer2->IsPossiblyComplete());
+ EXPECT_EQ(kCompleteValue, framebuffer2->IsPossiblyComplete(false));
framebuffer_manager2.MarkAsComplete(framebuffer2.get());
EXPECT_TRUE(framebuffer_manager2.IsComplete(framebuffer2.get()));
@@ -2317,11 +2317,11 @@ TEST_F(SharedTextureTest, FBOCompletenessCheck) {
GL_UNSIGNED_BYTE,
true);
EXPECT_FALSE(framebuffer_manager1.IsComplete(framebuffer1.get()));
- EXPECT_EQ(kCompleteValue, framebuffer1->IsPossiblyComplete());
+ EXPECT_EQ(kCompleteValue, framebuffer1->IsPossiblyComplete(false));
framebuffer_manager1.MarkAsComplete(framebuffer1.get());
EXPECT_TRUE(framebuffer_manager1.IsComplete(framebuffer1.get()));
EXPECT_FALSE(framebuffer_manager2.IsComplete(framebuffer2.get()));
- EXPECT_EQ(kCompleteValue, framebuffer2->IsPossiblyComplete());
+ EXPECT_EQ(kCompleteValue, framebuffer2->IsPossiblyComplete(false));
framebuffer_manager2.MarkAsComplete(framebuffer2.get());
EXPECT_TRUE(framebuffer_manager2.IsComplete(framebuffer2.get()));

Powered by Google App Engine
This is Rietveld 408576698