Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 139013008: Implement support for rendering to 32-bit float textures on ES3 (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/framebuffer_manager.h
diff --git a/gpu/command_buffer/service/framebuffer_manager.h b/gpu/command_buffer/service/framebuffer_manager.h
index c469bf8743503a90eccdb57dad657f6477667414..0472945f6de5cefbbfd380cc4e1fc2d9f7cdf2b5 100644
--- a/gpu/command_buffer/service/framebuffer_manager.h
+++ b/gpu/command_buffer/service/framebuffer_manager.h
@@ -17,6 +17,7 @@
namespace gpu {
namespace gles2 {
+class FeatureInfo;
class FramebufferManager;
class Renderbuffer;
class RenderbufferManager;
@@ -46,7 +47,8 @@ class GPU_EXPORT Framebuffer : public base::RefCounted<Framebuffer> {
virtual bool CanRenderTo() const = 0;
virtual void DetachFromFramebuffer(Framebuffer* framebuffer) const = 0;
virtual bool ValidForAttachmentType(
- GLenum attachment_type, uint32 max_color_attachments) = 0;
+ GLenum attachment_type, uint32 max_color_attachments,
+ const FeatureInfo* feature_info) = 0;
virtual void AddToSignature(
TextureManager* texture_manager, std::string* signature) const = 0;
@@ -115,7 +117,7 @@ class GPU_EXPORT Framebuffer : public base::RefCounted<Framebuffer> {
// Note that receiving GL_FRAMEBUFFER_COMPLETE from this function does
// not mean the real OpenGL will consider it framebuffer complete. It just
// means it passed our tests.
- GLenum IsPossiblyComplete() const;
+ GLenum IsPossiblyComplete(const FeatureInfo* feature_info) const;
// Implements optimized glGetFramebufferStatus.
GLenum GetStatus(TextureManager* texture_manager, GLenum target) const;

Powered by Google App Engine
This is Rietveld 408576698