Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 139013005: Reland "Remove flags argument from EmitCallWithStub" and corresponding MIPS CL (Closed)

Created:
6 years, 11 months ago by Michael Achenbach
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reland "Remove flags argument from EmitCallWithStub" and "MIPS: Remove flags argument from EmitCallWithStub."" This reverts commit r18606 since suspected problems still remained. BUG= R=jkummerow@chromium.org TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M src/arm/full-codegen-arm.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 11 months ago (2014-01-15 09:04:08 UTC) #1
Jakob Kummerow
lgtm
6 years, 11 months ago (2014-01-15 09:04:49 UTC) #2
Michael Achenbach
6 years, 11 months ago (2014-01-15 09:05:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18609.

Powered by Google App Engine
This is Rietveld 408576698