Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1390123002: (WIP) Paint property hierarchy approach 1 of 2 (Closed)

Created:
5 years, 2 months ago by pdr.
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, blink-layers+watch_chromium.org, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, Rik, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, danakj, krit, f(malita), blink-reviews, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(WIP) Paint property hierarchy approach 1 of 2 This patch implements one approach for storing the paint property hierarchy using axillary lists. This approach has a few downsides: 1) No mapping from layout object to paint property. Because paint needs to be able to lookup the properties generated during UpdatePaintProperties, we would need some mechanism to lookup the current property. 2) There are potentially many layouts for just a single paint. Because it is likely the property generation step will get folded into layout, we need a design that is cache-friendly and can be updated instead of actually generated from a complete treewalk after every layout. Updating the auxiliary vector of paint properties may not be efficient. approach 2 of 2 forthcoming.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -37 lines) Patch
M third_party/WebKit/Source/platform/blink_platform.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CompositedDisplayList.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 5 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemTransformTree.h View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.h View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp View 3 chunks +60 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintProperties.h View 1 chunk +9 lines, -7 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/TransformPaintProperty.h View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/PaintPrinters.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/PaintPrinters.cpp View 2 chunks +35 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698